[Remoting Android] Fix GetWeakPtr() calls on multiple threads

remoting/client/jni/jni_display_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/jni/jni_display_handler.h"
 
 #include "base/android/jni_android.h"
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
@@ skipping 37 matching lines @@
   task_runner_->PostTask(FROM_HERE,
                          base::Bind(&JniDisplayHandler::UpdateCursorShape,
                                     display_handler_,
                                     cursor_shape));
 }
 
 // JniDisplayHandler definitions.
 JniDisplayHandler::JniDisplayHandler(ChromotingJniRuntime* runtime)
     : runtime_(runtime),
       weak_factory_(this) {
+  weak_ptr_ = weak_factory_.GetWeakPtr();
   JNIEnv* env = base::android::AttachCurrentThread();
   java_display_.Reset(Java_Display_createJavaDisplayObject(
       env, reinterpret_cast<intptr_t>(this)));
 }
 
 JniDisplayHandler::~JniDisplayHandler() {
   DCHECK(runtime_->display_task_runner()->BelongsToCurrentThread());
   Java_Display_invalidate(base::android::AttachCurrentThread(),
                           java_display_.obj());
 }
@@ skipping 20 matching lines @@
   base::android::ScopedJavaLocalRef<jobject> buffer(
       env, env->NewDirectByteBuffer(data, cursor_total_bytes));
   Java_Display_updateCursorShape(
       env, java_display_.obj(), cursor_shape.width(), cursor_shape.height(),
       cursor_shape.hotspot_x(), cursor_shape.hotspot_y(), buffer.obj());
 }
 
 std::unique_ptr<protocol::CursorShapeStub>
 JniDisplayHandler::CreateCursorShapeStub() {
   return base::WrapUnique(
-      new DisplayCursorShapeStub(weak_factory_.GetWeakPtr(),
-                                 runtime_->display_task_runner()));
+      new DisplayCursorShapeStub(weak_ptr_, runtime_->display_task_runner()));
 }
 
 std::unique_ptr<protocol::VideoRenderer>
 JniDisplayHandler::CreateVideoRenderer() {
   return base::WrapUnique(
-      new JniVideoRenderer(runtime_, weak_factory_.GetWeakPtr()));
+      new JniVideoRenderer(runtime_, weak_ptr_));
 }
 
 // static
 base::android::ScopedJavaLocalRef<jobject> JniDisplayHandler::NewBitmap(
     int width,
     int height) {
   JNIEnv* env = base::android::AttachCurrentThread();
   return Java_Display_newBitmap(env, width, height);
 }
 
@@ skipping 14 matching lines @@
 
 // static
 bool JniDisplayHandler::RegisterJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 void JniDisplayHandler::ScheduleRedraw(
     JNIEnv* env,
     const base::android::JavaParamRef<jobject>& caller) {
   runtime_->display_task_runner()->PostTask(
-      FROM_HERE, base::Bind(&JniDisplayHandler::RedrawCanvas,
-                            weak_factory_.GetWeakPtr()));
+      FROM_HERE, base::Bind(&JniDisplayHandler::RedrawCanvas, weak_ptr_));
 }
 
 }  // namespace remoting