Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2142223002:
webgl: Handle null context provider when trying to restore context (Closed)
Descriptionwebgl: Handle null context provider when trying to restore context
If the gpu process is gone, the context provider may be null, so
we must handle that scenario in the maybeRestoreContext method.
BUG=627240
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/6656a4ec329fe67023e1e41576ca8f3ad9585078
Cr-Commit-Position: refs/heads/master@{#404857}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 ========== to ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
danakj@chromium.org changed reviewers: + kbr@chromium.org, zmo@chromium.org
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM though I wonder if more race conditions exist in this code.
On 2016/07/12 21:49:51, Ken Russell wrote: > LGTM though I wonder if more race conditions exist in this code. Not sure, we caught this error on the other create path much earlier and so now this matches it.
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel NOTRY=true ==========
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel NOTRY=true ========== to ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel NOTRY=true ========== to ========== webgl: Handle null context provider when trying to restore context If the gpu process is gone, the context provider may be null, so we must handle that scenario in the maybeRestoreContext method. BUG=627240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/6656a4ec329fe67023e1e41576ca8f3ad9585078 Cr-Commit-Position: refs/heads/master@{#404857} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6656a4ec329fe67023e1e41576ca8f3ad9585078 Cr-Commit-Position: refs/heads/master@{#404857} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
