third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2142223002: webgl: Handle null context provider when trying to restore context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2142223002: webgl: Handle null context provider when trying to restore context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index ebed1a63bf97b77e8b8df2cf6e7183f5125193fd..382461c703c64665f2e99c81d76000f1b684f06d 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -6152,7 +6152,7 @@ void WebGLRenderingContextBase::maybeRestoreContext(Timer<WebGLRenderingContextB

std::unique_ptr<WebGraphicsContext3DProvider> contextProvider = wrapUnique(Platform::current()->createOffscreenGraphicsContext3DProvider(

attributes, canvas()->document().topDocument().url(), 0, &glInfo));

RefPtr<DrawingBuffer> buffer;

- if (contextProvider->bindToCurrentThread()) {

+ if (contextProvider && contextProvider->bindToCurrentThread()) {

// Construct a new drawing buffer with the new GL context.

buffer = createDrawingBuffer(std::move(contextProvider));

// If DrawingBuffer::create() fails to allocate a fbo, |drawingBuffer| is set to null.

« no previous file with comments | « no previous file | no next file » | no next file with comments »