third_party/WebKit/Source/core/input/EventHandler.h - Issue 2141993003: PointerEvents for long-press: fix double firing & canceling MEs

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 2141993003: PointerEvents for long-press: fix double firing & canceling MEs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-long-press.html ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.h

diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h

index 3f44d21a35070704b772816d16cae56856c44d84..7d69002b5e1624b674860a6c0437499600f4501e 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.h

+++ b/third_party/WebKit/Source/core/input/EventHandler.h

@@ -146,7 +146,7 @@ public:

WebInputEventResult handleMouseMoveEvent(const PlatformMouseEvent&);

void handleMouseLeaveEvent(const PlatformMouseEvent&);

- WebInputEventResult handleMousePressEvent(const PlatformMouseEvent&);

+ WebInputEventResult handleMousePressEvent(const PlatformMouseEvent&, const bool synthesizedFromTouch = false);

Rick Byers 2016/07/14 14:27:10 PlatformMouseEvent already has a fromTouch() prope

mustaq 2016/07/18 20:50:15 Done.

WebInputEventResult handleMouseReleaseEvent(const PlatformMouseEvent&);

WebInputEventResult handleWheelEvent(const PlatformWheelEvent&);

@@ -274,7 +274,6 @@ private:

Node* updateMouseEventTargetNode(Node*, const PlatformMouseEvent&);

void updateMouseEventTargetNodeAndSendEvents(Node*, const PlatformMouseEvent&, bool isFrameBoundaryTransition = false);

MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);

WebInputEventResult dispatchMouseEvent(const AtomicString& eventType, Node* target, int clickCount, const PlatformMouseEvent&);

@@ -285,7 +284,7 @@ private:

// TODO(mustaq): Can we avoid the clickCount param, instead use PlatformMouseEvent's count?

// Same applied to dispatchMouseEvent() above.

WebInputEventResult updatePointerTargetAndDispatchEvents(const AtomicString& mouseEventType, Node* target,

- int clickCount, const PlatformMouseEvent&);

+ int clickCount, const PlatformMouseEvent&, const bool synthesizedFromTouch = false);

Rick Byers 2016/07/14 14:27:10 ditto

mustaq 2016/07/18 20:50:15 Done.

WebInputEventResult dispatchDragEvent(const AtomicString& eventType, Node* target, const PlatformMouseEvent&, DataTransfer*);