PointerEvents for long-press: fix double firing & canceling MEs

third_party/WebKit/Source/core/input/EventHandler.h

 /*
  * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 128 matching lines @@
 
     IntPoint dragDataTransferLocationForTesting();
 
     // Performs a logical scroll that chains, crossing frames, starting from
     // the given node or a reasonable default (focus/last clicked).
     bool bubblingScroll(ScrollDirection, ScrollGranularity, Node* startingNode = nullptr);
 
     WebInputEventResult handleMouseMoveEvent(const PlatformMouseEvent&);
     void handleMouseLeaveEvent(const PlatformMouseEvent&);
 
-    WebInputEventResult handleMousePressEvent(const PlatformMouseEvent&);
+    WebInputEventResult handleMousePressEvent(const PlatformMouseEvent&, const bool synthesizedFromTouch = false);

[Rick Byers, 2016/07/14 14:27:10]

PlatformMouseEvent already has a fromTouch() property, can you use that rather
than introduce a redundant-looking additional piece of state?

[mustaq, 2016/07/18 20:50:15]

Done.

     WebInputEventResult handleMouseReleaseEvent(const PlatformMouseEvent&);
     WebInputEventResult handleWheelEvent(const PlatformWheelEvent&);
 
     // Called on the local root frame exactly once per gesture event.
     WebInputEventResult handleGestureEvent(const PlatformGestureEvent&);
     WebInputEventResult handleGestureEvent(const GestureEventWithHitTestResults&);
 
     // Clear the old hover/active state within frames before moving the hover state to the another frame
     void updateGestureHoverActiveState(const HitTestRequest&, Element*);
 
@@ skipping 107 matching lines @@
     bool isCursorVisible() const;
     void updateCursor();
 
     ScrollableArea* associatedScrollableArea(const PaintLayer*) const;
 
     void invalidateClick();
 
     Node* updateMouseEventTargetNode(Node*, const PlatformMouseEvent&);
     void updateMouseEventTargetNodeAndSendEvents(Node*, const PlatformMouseEvent&, bool isFrameBoundaryTransition = false);
 
-
     MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);
 
     WebInputEventResult dispatchMouseEvent(const AtomicString& eventType, Node* target, int clickCount, const PlatformMouseEvent&);
 
     // Dispatches ME after corresponding PE provided the PE has not been canceled. The eventType arg
     // must be a mouse event that can be gated though a preventDefaulted pointerdown (i.e., one of
     // {mousedown, mousemove, mouseup}).
     // TODO(mustaq): Can we avoid the clickCount param, instead use PlatformMouseEvent's count?
     //     Same applied to dispatchMouseEvent() above.
     WebInputEventResult updatePointerTargetAndDispatchEvents(const AtomicString& mouseEventType, Node* target,
-        int clickCount, const PlatformMouseEvent&);
+        int clickCount, const PlatformMouseEvent&, const bool synthesizedFromTouch = false);

[Rick Byers, 2016/07/14 14:27:10]

ditto

[mustaq, 2016/07/18 20:50:15]

Done.

 
     WebInputEventResult dispatchDragEvent(const AtomicString& eventType, Node* target, const PlatformMouseEvent&, DataTransfer*);
 
     void clearDragDataTransfer();
 
     bool handleDrag(const MouseEventWithHitTestResults&, DragInitiator);
     bool tryStartDrag(const MouseEventWithHitTestResults&);
 
     // Clears drag target and related states. It is called when drag is done or canceled.
     void clearDragState();
@@ skipping 104 matching lines @@
 
     // Set on GestureTapDown if the |pointerdown| event corresponding to the
     // triggering |touchstart| event was canceled. This suppresses mouse event
     // firing for the current gesture sequence (i.e. until next GestureTapDown).
     bool m_suppressMouseEventsFromGestures;
 };
 
 } // namespace blink
 
 #endif // EventHandler_h