[Turbofan]: Add integer multiplication with overflow to typed lowering.

[Turbofan]: Add integer multiplication with overflow to typed lowering.

BUG=

Committed: https://crrev.com/e7111cfff7d73786aeb5d7ed579103137f532748
Cr-Commit-Position: refs/heads/master@{#37764}

[mvstanton, 2016-07-14 11:14:57]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2016-07-14 11:14:58]

Hi Benedikt, here is the CL we've discussed.
I had to keep the check for truncation in kSpeculativeNumberMultiply in the case
that we had a signedsmall or signed32 hint to avoid failing some tests.
PTAL, thx!
--Mike

[Benedikt Meurer, 2016-07-14 11:41:35]

Awesome thanks. Please remove the dead code, then it's ready to go in.
LGTM.

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/js-graph.cc
File src/compiler/js-graph.cc (right):

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/js-graph.c...
src/compiler/js-graph.cc:96: return CACHED(kMinusZeroConstant,
Remove this one.

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/js-graph.h...
src/compiler/js-graph.h:57: Node* MinusZeroConstant();
Remove this one, you don't need it.

[Benedikt Meurer, 2016-07-14 11:43:00]

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:1364: if (BothInputsAre(node,
Type::Number())) {
This whole if block is redundant. Drop it as well.

[Benedikt Meurer, 2016-07-14 12:08:23]

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2141953002/diff/80001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:1350: // If the result is truncated, we only
need to check the inputs.
Also as discussed offline, this code is wrong, please remove it (the truncation
case).

[mvstanton, 2016-07-14 12:54:31]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-07-14 12:54:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2141953002/#ps100001
(title: "Code comments.")

[commit-bot: I haz the power, 2016-07-14 12:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 13:22:01]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-14 13:25:20]

Description was changed from

==========
[Turbofan]: Add integer multiplication with overflow to typed lowering.

BUG=
==========

to

==========
[Turbofan]: Add integer multiplication with overflow to typed lowering.

BUG=

Committed: https://crrev.com/e7111cfff7d73786aeb5d7ed579103137f532748
Cr-Commit-Position: refs/heads/master@{#37764}
==========

[commit-bot: I haz the power, 2016-07-14 13:25:22]

Patchset 6 (id:??) landed as
https://crrev.com/e7111cfff7d73786aeb5d7ed579103137f532748
Cr-Commit-Position: refs/heads/master@{#37764}