| Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
|
| diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
|
| index 6e6f965b058ad9fab999be97fa0a462f5c26fb1a..7583db6115a3681cb35a7790fa01a6c7a90cedcb 100644
|
| --- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
|
| +++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
|
| @@ -20,8 +20,7 @@ class WebContents;
|
|
|
| // Helper class for logging data from the NTP. Attached to each NTP instance.
|
| class NTPUserDataLogger
|
| - : public content::WebContentsObserver,
|
| - public content::WebContentsUserData<NTPUserDataLogger> {
|
| + : public content::WebContentsUserData<NTPUserDataLogger> {
|
| public:
|
| ~NTPUserDataLogger() override;
|
|
|
| @@ -39,12 +38,6 @@ class NTPUserDataLogger
|
| // Logs a navigation on one of the NTP tiles by a given source.
|
| void LogMostVisitedNavigation(int position, NTPLoggingTileSource tile_source);
|
|
|
| - // Called when the tab is closed. Logs statistics.
|
| - void TabDeactivated();
|
| -
|
| - // Called when the set of most visited sites changes. Flushes statistics.
|
| - void MostVisitedItemsChanged();
|
| -
|
| protected:
|
| explicit NTPUserDataLogger(content::WebContents* contents);
|
|
|
| @@ -58,20 +51,10 @@ class NTPUserDataLogger
|
| FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest,
|
| TestLogging);
|
|
|
| - // content::WebContentsObserver override
|
| - void NavigationEntryCommitted(
|
| - const content::LoadCommittedDetails& load_details) override;
|
| -
|
| - // To clarify at the call site whether we are calling EmitNtpStatistics() for
|
| - // a good reason (CLOSED, NAVIGATED_AWAY) or a questionable one (MV_CHANGED,
|
| - // INTERNAL_FLUSH).
|
| - // TODO(sfiera): remove MV_CHANGED, INTERNAL_FLUSH.
|
| - enum class EmitReason { CLOSED, NAVIGATED_AWAY, MV_CHANGED, INTERNAL_FLUSH };
|
| -
|
| // Logs a number of statistics regarding the NTP. Called when an NTP tab is
|
| // about to be deactivated (be it by switching tabs, losing focus or closing
|
| // the tab/shutting down Chrome), or when the user navigates to a URL.
|
| - void EmitNtpStatistics(EmitReason reason);
|
| + void EmitNtpStatistics();
|
|
|
| // True if at least one iframe came from a server-side suggestion.
|
| bool has_server_side_suggestions_;
|
|
|