Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/local_ntp/most_visited_single.js

Issue 2141933002: Split NTP_TILE_LOADED event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_instant_controller.cc » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_single.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_single.js b/chrome/browser/resources/local_ntp/most_visited_single.js
index 817fd76b0dc1c4c7583f9d10655030e57cf16ff6..a5189e33615358ea8e70332ecbbcda520a77f112 100644
--- a/chrome/browser/resources/local_ntp/most_visited_single.js
+++ b/chrome/browser/resources/local_ntp/most_visited_single.js
@@ -24,7 +24,7 @@ var LOG_TYPE = {
// or an external tile.
NTP_TILE: 2,
// A NTP Tile has finished loading (successfully or failing).
Marc Treib 2016/07/12 12:40:09 Please update the comment.
sfiera 2016/07/12 13:21:21 Done.
- NTP_TILE_LOADED: 10,
+ NTP_ALL_TILES_LOADED: 11,
};
@@ -133,7 +133,7 @@ var countLoad = function() {
loadedCounter -= 1;
if (loadedCounter <= 0) {
showTiles();
- logEvent(LOG_TYPE.NTP_TILE_LOADED);
+ logEvent(LOG_TYPE.NTP_ALL_TILES_LOADED);
window.parent.postMessage({cmd: 'loaded'}, DOMAIN_ORIGIN);
loadedCounter = 1;
}
« no previous file with comments | « no previous file | chrome/browser/ui/browser_instant_controller.cc » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698