Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2141933002: Split NTP_TILE_LOADED event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 2ba04505a85de5bc8d11a6e6b0628dafb7a04f54..3ff3225effe808b617a10aaabdf5f0f290800216 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -385,28 +385,7 @@ void SearchTabHelper::ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) {
void SearchTabHelper::MostVisitedItemsChanged(
const std::vector<InstantMostVisitedItem>& items) {
- // When most visited change, the NTP usually reloads the tiles. This means
- // our metrics get inconsistent. So we'd rather emit stats now.
- InstantTab::MostVisitedItemsChanged(web_contents_);
ipc_router_.SendMostVisitedItems(items);
- LogMostVisitedItemsSource(items);
-}
-
-void SearchTabHelper::LogMostVisitedItemsSource(
- const std::vector<InstantMostVisitedItem>& items) {
- for (auto item : items) {
- NTPLoggingEventType event;
- if (item.is_server_side_suggestion) {
- event = NTP_SERVER_SIDE_SUGGESTION;
- } else {
- event = NTP_CLIENT_SIDE_SUGGESTION;
- }
- // The metrics are emitted for each suggestion as the design requirement
- // even the ntp_user_data_logger.cc now only supports the scenario:
- // all suggestions are provided by server OR
- // all suggestions are provided by client.
- this->OnLogEvent(event, base::TimeDelta());
- }
}
void SearchTabHelper::FocusOmnibox(OmniboxFocusState state) {
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.h ('k') | chrome/browser/ui/search/search_tab_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698