Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 2141933002: Split NTP_TILE_LOADED event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper_unittest.cc
diff --git a/chrome/browser/ui/search/search_tab_helper_unittest.cc b/chrome/browser/ui/search/search_tab_helper_unittest.cc
index eda53e3489f2f44dc543e29902b445bfa7e049fe..357c77eb59980ccaf9b0016d7666774a34f2a0f7 100644
--- a/chrome/browser/ui/search/search_tab_helper_unittest.cc
+++ b/chrome/browser/ui/search/search_tab_helper_unittest.cc
@@ -320,46 +320,6 @@ TEST_F(SearchTabHelperTest, OnHistorySyncCheckNotSyncing) {
ASSERT_FALSE(std::get<0>(params));
}
-TEST_F(SearchTabHelperTest, OnMostVisitedItemsChangedFromServer) {
- InstantMostVisitedItem item;
- item.is_server_side_suggestion = true;
- std::vector<InstantMostVisitedItem> items;
- items.push_back(item);
-
- SearchTabHelper* search_tab_helper =
- SearchTabHelper::FromWebContents(web_contents());
- ASSERT_NE(static_cast<SearchTabHelper*>(NULL), search_tab_helper);
-
- auto logger = NTPUserDataLogger::GetOrCreateFromWebContents(web_contents());
- ASSERT_FALSE(logger->has_server_side_suggestions_);
- ASSERT_FALSE(logger->has_client_side_suggestions_);
-
- search_tab_helper->MostVisitedItemsChanged(items);
-
- ASSERT_TRUE(logger->has_server_side_suggestions_);
- ASSERT_FALSE(logger->has_client_side_suggestions_);
-}
-
-TEST_F(SearchTabHelperTest, OnMostVisitedItemsChangedFromClient) {
- InstantMostVisitedItem item;
- item.is_server_side_suggestion = false;
- std::vector<InstantMostVisitedItem> items;
- items.push_back(item);
-
- SearchTabHelper* search_tab_helper =
- SearchTabHelper::FromWebContents(web_contents());
- ASSERT_NE(static_cast<SearchTabHelper*>(NULL), search_tab_helper);
-
- auto logger = NTPUserDataLogger::GetOrCreateFromWebContents(web_contents());
- ASSERT_FALSE(logger->has_server_side_suggestions_);
- ASSERT_FALSE(logger->has_client_side_suggestions_);
-
- search_tab_helper->MostVisitedItemsChanged(items);
-
- ASSERT_FALSE(logger->has_server_side_suggestions_);
- ASSERT_TRUE(logger->has_client_side_suggestions_);
-}
-
class TabTitleObserver : public content::WebContentsObserver {
public:
explicit TabTitleObserver(content::WebContents* contents)
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698