Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: mojo/apps/js/mojo_runner_delegate.cc

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm.extra.gc Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/apps/js/mojo_runner_delegate.cc
diff --git a/mojo/apps/js/mojo_runner_delegate.cc b/mojo/apps/js/mojo_runner_delegate.cc
index 2a6c1bd5d9ee66479b6210f766f8a16d17faa959..13081e48f3eff658d83d3f1a9e81c9809ef89739 100644
--- a/mojo/apps/js/mojo_runner_delegate.cc
+++ b/mojo/apps/js/mojo_runner_delegate.cc
@@ -15,6 +15,7 @@
#include "mojo/apps/js/bindings/monotonic_clock.h"
#include "mojo/apps/js/bindings/threading.h"
#include "mojo/bindings/js/core.h"
+#include "mojo/bindings/js/handle.h"
#include "mojo/bindings/js/support.h"
namespace mojo {
@@ -39,7 +40,8 @@ void StartCallback(base::WeakPtr<gin::Runner> runner,
v8::Handle<v8::Function> start;
CHECK(gin::ConvertFromV8(isolate, module, &start));
- v8::Handle<v8::Value> args[] = { gin::ConvertToV8(isolate, pipe) };
+ v8::Handle<v8::Value> args[] = {
+ gin::ConvertToV8(isolate, mojo::Handle(pipe)) };
runner->Call(start, runner->global(), 1, args);
}

Powered by Google App Engine
This is Rietveld 408576698