mojo/apps/js/bindings/connection_unittests.js - Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/bindings/connection_unittests.js

Issue 214183003: Change mojo JS bindings to expose a handle object, which is Closed when garbage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rm.extra.gc Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/apps/js/bindings/connection_unittests.js

diff --git a/mojo/apps/js/bindings/connection_unittests.js b/mojo/apps/js/bindings/connection_unittests.js

index 3a578203fef74fbb453f87257d2f26e5a76b450f..60b867d1aa11ccc9cfae190d5017e7910d39b1e4 100644

--- a/mojo/apps/js/bindings/connection_unittests.js

+++ b/mojo/apps/js/bindings/connection_unittests.js

@@ -53,16 +53,19 @@ define([

"mojo/public/bindings/js/connection",

"mojo/public/interfaces/bindings/tests/sample_interfaces.mojom",

"mojo/public/interfaces/bindings/tests/sample_service.mojom",

+ "gc",

], function(expect,

mockSupport,

core,

connection,

sample_interfaces,

- sample_service) {

+ sample_service,

+ gc) {

testClientServer();

testWriteToClosedPipe();

testRequestResponse();

this.result = "PASS";

+ gc.collectGarbage(); // should not crash

function testClientServer() {

var receivedFrobinate = false;

« no previous file with comments | « gin/test/gc.cc ('k') | mojo/apps/js/mojo_runner_delegate.cc » ('j') | mojo/bindings/js/core.cc » ('J')