Issue 2141763002: Hot reload fixes for isolate tests

Issue 2141763002: Hot reload fixes for isolate tests (Closed)

Created:
4 years, 5 months ago by Cutch

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Hot reload fixes for isolate tests - [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....) - [x] Only check that an isolate has reload if it was ever runnable. - [x] Skip some isolate tests that use deferred libraries or are checking for closure identity. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/24a0988df685ad32cbddfd0954721699d3ae107b

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	runtime/bin/main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate.status	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (4 generated)

Cutch

4 years, 5 months ago (2016-07-11 20:58:31 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
24a0988df685ad32cbddfd0954721699d3ae107b (presubmit successful).