runtime/vm/isolate.cc - Issue 2141763002: Hot reload fixes for isolate tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 2141763002: Hot reload fixes for isolate tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ... Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index 85916601982b363f9fd6887461951e51519ae322..5dc9a9f6b4807f08f4723738baa3015ba23522fe 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1718,7 +1718,7 @@ void Isolate::Shutdown() {

}

- if (FLAG_check_reloaded &&

+ if (FLAG_check_reloaded && is_runnable() &&

(this != Dart::vm_isolate()) &&

!ServiceIsolate::IsServiceIsolateDescendant(this)) {

if (!HasAttemptedReload()) {

« no previous file with comments | « runtime/bin/main.cc ('k') | tests/isolate/isolate.status » ('j') | no next file with comments »