third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html - Issue 2141743002: Use node() when generating element id's

Unified Diff: third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

Issue 2141743002: Use node() when generating element id's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation-expected.html » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

diff --git a/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html b/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

new file mode 100644

index 0000000000000000000000000000000000000000..7f3cd80006d790aa3aa87c9a66c2afbf71d5f0e6

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

@@ -0,0 +1,32 @@

+<!DOCTYPE html>

+<style>

+div {

+ width: 100px;

+ height: 100px;

+ background: orange;

+div:before {

jbroman 2016/07/11 21:04:38 Please use ::before, here and below. The single-co

Ian Vollick 2016/07/11 21:45:22 Done.

+ content: ":)";

+ transform: translateZ(0);

jbroman 2016/07/11 21:04:38 nit: Is this the right compositing hint here? Woul

Ian Vollick 2016/07/11 21:45:22 Not needed at all, actually.

+ transition-property: transform;

+ transition-duration: 1ms;

+ position: absolute;

jbroman 2016/07/11 21:04:38 Is absolute positioning significant in this test?

Ian Vollick 2016/07/11 21:45:22 Turns out it just needs to be a "transformable" el

+</style>

+<div></div>

+<script>

+if (testRunner)

+ testRunner.waitUntilDone();

+onload = function() {

jbroman 2016/07/11 21:04:38 Is it necessary to block on the load event?

Ian Vollick 2016/07/11 21:45:22 Nope. Removed.

+ requestAnimationFrame(function(ts) {

+ document.styleSheets[0].addRule('div:before', 'transform: translateX(20px)');

+ requestAnimationFrame(function(ts) {

+ if (testRunner)

+ testRunner.notifyDone();

+ });

+</script>