third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html - Issue 2141743002: Use node() when generating element id's

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation.html

Issue 2141743002: Use node() when generating element id's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-pseudo-element-animation-expected.html » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 div {

	4 width: 100px;

	5 height: 100px;

	6 background: orange;

	7 }

	8 div:before {
	jbroman 2016/07/11 21:04:38 Please use ::before, here and below. The single-co Please use ::before, here and below. The single-colon syntax is deprecated for pseudo-elements (and is reserved for pseudo-classes, with the exception of backwards compatibility). Ian Vollick 2016/07/11 21:45:22 Done. Show quoted text On 2016/07/11 at 21:04:38, jbroman wrote: > Please use ::before, here and below. The single-colon syntax is deprecated for pseudo-elements (and is reserved for pseudo-classes, with the exception of backwards compatibility). Done.
	9 content: ":)";

	10 transform: translateZ(0);
	jbroman 2016/07/11 21:04:38 nit: Is this the right compositing hint here? Woul nit: Is this the right compositing hint here? Would it be clearer to write 'will-change: transform'? Ian Vollick 2016/07/11 21:45:22 Not needed at all, actually. Show quoted text On 2016/07/11 at 21:04:38, jbroman wrote: > nit: Is this the right compositing hint here? Would it be clearer to write 'will-change: transform'? Not needed at all, actually.
	11 transition-property: transform;

	12 transition-duration: 1ms;

	13 position: absolute;
	jbroman 2016/07/11 21:04:38 Is absolute positioning significant in this test? Is absolute positioning significant in this test? Ian Vollick 2016/07/11 21:45:22 Turns out it just needs to be a "transformable" el Show quoted text On 2016/07/11 at 21:04:38, jbroman wrote: > Is absolute positioning significant in this test? Turns out it just needs to be a "transformable" element. I've changed this to display:block and linked to the spec prose to explain why it's there.
	14 }

	15 </style>

	16 <div></div>

	17 <script>

	18 if (testRunner)

	19 testRunner.waitUntilDone();

	20

	21 onload = function() {
	jbroman 2016/07/11 21:04:38 Is it necessary to block on the load event? Is it necessary to block on the load event? Ian Vollick 2016/07/11 21:45:22 Nope. Removed. Show quoted text On 2016/07/11 at 21:04:38, jbroman wrote: > Is it necessary to block on the load event? Nope. Removed.
	22 requestAnimationFrame(function(ts) {

	23 document.styleSheets[0].addRule('div:before', 'transform: translateX(20px)' );

	24 requestAnimationFrame(function(ts) {

	25 requestAnimationFrame(function(ts) {

	26 if (testRunner)

	27 testRunner.notifyDone();

	28 });

	29 });

	30 });

	31 }

	32 </script>

OLD	NEW