[Android] Fix handling of intentional crashes during death tests.

[Android] Fix handling of intentional crashes during death tests.

BUG=620898
R=mikecase@chromium.org, rnephew@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c4f4073a28689b275f41aa83679627d719e8884a

[jbudorick, 2016-07-11 19:46:33]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org, rnephew@chromium.org

[mikecase (-- gone --), 2016-07-11 21:15:04]

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
File build/android/pylib/gtest/gtest_test_instance.py (right):

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:147: def
handle_possibly_unknown_test():
I'm kinda confused on what this CL is doing. Why is fallback_result_type
necessary?

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:161: fallback_result_type =
None
Do you want to set these two things before calling
handle_possibly_unknown_tests() (called on the line before this?)

[rnephew (Reviews Here), 2016-07-11 21:23:54]

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
File build/android/pylib/gtest/gtest_test_instance.py (right):

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:161: fallback_result_type =
None
On 2016/07/11 21:15:04, mikecase wrote:
> Do you want to set these two things before calling
> handle_possibly_unknown_tests() (called on the line before this?)
> 

Thats for the step before it in the for loop.

[rnephew (Reviews Here), 2016-07-11 21:24:00]

On 2016/07/11 21:23:54, rnephew (Reviews Here) wrote:
>
https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
> File build/android/pylib/gtest/gtest_test_instance.py (right):
> 
>
https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
> build/android/pylib/gtest/gtest_test_instance.py:161: fallback_result_type =
> None
> On 2016/07/11 21:15:04, mikecase wrote:
> > Do you want to set these two things before calling
> > handle_possibly_unknown_tests() (called on the line before this?)
> > 
> 
> Thats for the step before it in the for loop.

lgtm

[jbudorick, 2016-07-11 21:29:36]

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
File build/android/pylib/gtest/gtest_test_instance.py (right):

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:147: def
handle_possibly_unknown_test():
On 2016/07/11 21:15:04, mikecase wrote:
> I'm kinda confused on what this CL is doing. Why is fallback_result_type
> necessary?

This CL essentially switches from treating [ +CRASHED +] as a terminating test
log message to a nonterminating one because it may not be the end of the test. I
didn't realize that when I initially wrote this.

In death tests in particular, you can see something like this:

  [ RUN ] FooTest.Bar
  [ CRASHED         ]
  [ OK ] FooTest.Bar

This looks weird but is WAI and should be treated as a success because:
 - we install a signal handler in native_test_launcher.cc that prints CRASHED on
receiving any one of several signals
 - EXPECT_DEATH forks the process
 - the child inherits the parent's signal handlers and logs [ CRASHED ] when it
crashes
 - the parent sees that the child died and the EXPECT_DEATH assertion passes

If [ CRASHED ] actually _is_ the last thing we see from a test,
fallback_result_type ensures that we report that test as CRASH rather than
UNKNOWN.

https://codereview.chromium.org/2141723002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:161: fallback_result_type =
None
On 2016/07/11 21:15:04, mikecase wrote:
> Do you want to set these two things before calling
> handle_possibly_unknown_tests() (called on the line before this?)
> 

No. They, like test_name, are carried over from before in the event that a test
terminated in an unexpectedly silent fashion.

[mikecase (-- gone --), 2016-07-11 21:38:30]

lgtm

[jbudorick, 2016-07-11 21:38:59]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-11 21:39:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 22:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 22:49:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbudorick, 2016-07-11 22:51:04]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-11 22:52:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 23:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:42:44]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbudorick, 2016-07-11 23:44:43]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:48:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbudorick, 2016-07-12 01:51:10]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:52:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 03:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 03:17:09]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbudorick, 2016-07-12 14:21:03]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:21:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:51:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbudorick, 2016-07-12 15:52:12]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:53:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-07-12 16:02:40]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-07-12 16:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org, rnephew@chromium.org
Link to the patchset: https://codereview.chromium.org/2141723002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-12 16:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:08:11]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2016-07-12 18:20:55]

Description was changed from

==========
[Android] Fix handling of intentional crashes during death tests.

BUG=620898
==========

to

==========
[Android] Fix handling of intentional crashes during death tests.

BUG=620898
R=mikecase@chromium.org, rnephew@chromium.org

Committed: https://crrev.com/c4f4073a28689b275f41aa83679627d719e8884a
Cr-Commit-Position: refs/heads/master@{#404815}
==========

[commit-bot: I haz the power, 2016-07-12 18:20:56]

Patchset 2 (id:??) landed as
https://crrev.com/c4f4073a28689b275f41aa83679627d719e8884a
Cr-Commit-Position: refs/heads/master@{#404815}

[jbudorick, 2016-07-12 18:22:03]

Description was changed from

==========
[Android] Fix handling of intentional crashes during death tests.

BUG=620898
R=mikecase@chromium.org, rnephew@chromium.org

Committed: https://crrev.com/c4f4073a28689b275f41aa83679627d719e8884a
Cr-Commit-Position: refs/heads/master@{#404815}
==========

to

==========
[Android] Fix handling of intentional crashes during death tests.

BUG=620898
R=mikecase@chromium.org, rnephew@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/c4f4073a28689b275f41aa836796...
==========

[jbudorick, 2016-07-12 18:22:05]

Committed patchset #2 (id:20001) manually as
c4f4073a28689b275f41aa83679627d719e8884a (presubmit successful).