Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2410)

Unified Diff: testing/android/native_test/native_test_launcher.cc

Issue 2141723002: [Android] Fix handling of intentional crashes during death tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/native_test/native_test_launcher.cc
diff --git a/testing/android/native_test/native_test_launcher.cc b/testing/android/native_test/native_test_launcher.cc
index 3b5ee8328036995724e78db3404578468ed62cad..aadf06af48f958c30f4eb3f051dd2c36afce3014 100644
--- a/testing/android/native_test/native_test_launcher.cc
+++ b/testing/android/native_test/native_test_launcher.cc
@@ -50,7 +50,7 @@ struct sigaction g_old_sa[NSIG];
// This function runs in a compromised context. It should not allocate memory.
void SignalHandler(int sig, siginfo_t* info, void* reserved) {
// Output the crash marker.
- write(STDOUT_FILENO, kCrashedMarker, sizeof(kCrashedMarker));
+ write(STDOUT_FILENO, kCrashedMarker, sizeof(kCrashedMarker) - 1);
g_old_sa[sig].sa_sigaction(sig, info, reserved);
}
« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698