Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2141523002: Remove detailed from simple stack trace functionality (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove detailed from simple stack trace functionality This is another point where we add inconsistent behavior between simple and detailed stack traces. The functionality also does not seem to be used in chrome anymore when uncaught exceptions are thrown. Remove it to reduce maintenance burden. BUG=624285 R=yangguo@chromium.org Committed: https://crrev.com/a0c7ab6306262dad2c1b04d26354c5e8365b9aea Cr-Commit-Position: refs/heads/master@{#37673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -86 lines) Patch
M src/isolate.cc View 2 chunks +1 line, -52 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 5 months ago (2016-07-12 08:46:34 UTC) #5
Yang
On 2016/07/12 08:46:34, jgruber wrote: lgtm.
4 years, 5 months ago (2016-07-12 09:50:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141523002/1
4 years, 5 months ago (2016-07-12 09:54:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 10:22:59 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 10:25:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0c7ab6306262dad2c1b04d26354c5e8365b9aea
Cr-Commit-Position: refs/heads/master@{#37673}

Powered by Google App Engine
This is Rietveld 408576698