Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: test/cctest/test-api.cc

Issue 2141523002: Remove detailed from simple stack trace functionality (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 8cb94408570a082561a83974d521f83a9390e73b..f4bcf24471462b3f2c92adfb2c38b343e1d5a02e 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -16995,40 +16995,6 @@ TEST(CaptureStackTraceForUncaughtException) {
CHECK_EQ(1, report_count);
}
-
-TEST(GetStackTraceForUncaughtExceptionFromSimpleStackTrace) {
- report_count = 0;
- LocalContext env;
- v8::Isolate* isolate = env->GetIsolate();
- v8::HandleScope scope(isolate);
-
- // Create an Error object first.
- CompileRunWithOrigin(
- "function foo() {\n"
- "e=new Error('err');\n"
- "};\n"
- "function bar() {\n"
- " foo();\n"
- "};\n"
- "var e;",
- "origin");
- v8::Local<v8::Object> global = env->Global();
- Local<Value> trouble =
- global->Get(env.local(), v8_str("bar")).ToLocalChecked();
- CHECK(trouble->IsFunction());
- Function::Cast(*trouble)->Call(env.local(), global, 0, NULL).ToLocalChecked();
-
- // Enable capturing detailed stack trace late, and throw the exception.
- // The detailed stack trace should be extracted from the simple stack.
- isolate->AddMessageListener(StackTraceForUncaughtExceptionListener);
- isolate->SetCaptureStackTraceForUncaughtExceptions(true);
- CompileRunWithOrigin("throw e", "origin");
- isolate->SetCaptureStackTraceForUncaughtExceptions(false);
- isolate->RemoveMessageListeners(StackTraceForUncaughtExceptionListener);
- CHECK_EQ(1, report_count);
-}
-
-
TEST(CaptureStackTraceForUncaughtExceptionAndSetters) {
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698