[Password Generation] Checks the existence of the form even if the password was generated

[Password Generation] Checks the existence of the signin/signup form even if the password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was generated, there is no check whether the forms still exists. It was introduced to be sure Chrome saves the generated password. The disadvantage of it is that we send a positive vote to the server even if the login was failed (the vote says generation was successful).

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving of generated password (i.e. save generated password right after generation and update it after every user input).

Thus, we are sure that the generated password was saved. No need in the first CL (https://codereview.chromium.org/1237543002). Let remove its code since it distorts votes statistics.

BUG=552420
Committed: https://crrev.com/87a189f1566ce8cf72b77dac8cb54ec6bc4ab27c
Cr-Commit-Position: refs/heads/master@{#405093}

[kolos1, 2016-07-11 09:33:21]

Description was changed from

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated


BUG=552420
==========

to

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was
generated, there is no check whether the forms still exists. It was introduced
to be sure Chrome saves the generated password. The disadvantage of it is that
we send a positive vote to the server even if the login was failed (the vote
says generation was successful). 

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving
of generated password (i.e. save generated password right after generation and
update it after every user input). 

Thus, we are sure that the generated password was saved. No need in the first CL
(https://codereview.chromium.org/1237543002). Let remove its code since it
distorts votes statistics. 

BUG=552420
==========

[kolos1, 2016-07-11 09:47:44]

Patchset #1 (id:1) has been deleted

[kolos1, 2016-07-11 11:18:54]

Patchset #1 (id:20001) has been deleted

[kolos1, 2016-07-11 11:20:25]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org

[dvadym, 2016-07-11 11:46:40]

Thanks for fixing this, changes in code looks good. I have a comment about
changes in unittests.

https://codereview.chromium.org/2141513002/diff/40001/components/password_man...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/2141513002/diff/40001/components/password_man...
components/password_manager/core/browser/password_manager_unittest.cc:1127:
OnPasswordFormSubmitted(form);
I'm not sure what we check in this and the following test. I don't see any
EXPECT_CALL that checks that no save happens.

[kolos1, 2016-07-11 12:08:02]

Patchset #2 (id:60001) has been deleted

[kolos1, 2016-07-11 12:08:13]

Patchset #2 (id:80001) has been deleted

[kolos1, 2016-07-11 12:09:58]

https://codereview.chromium.org/2141513002/diff/40001/components/password_man...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/2141513002/diff/40001/components/password_man...
components/password_manager/core/browser/password_manager_unittest.cc:1127:
OnPasswordFormSubmitted(form);
On 2016/07/11 11:46:40, dvadym wrote:
> I'm not sure what we check in this and the following test. I don't see any
> EXPECT_CALL that checks that no save happens.

We expect that there will be no calls. But actually it would be better to
describe it explicitly. Fixed.

[dvadym, 2016-07-11 12:16:51]

LGTM

[kolos1, 2016-07-11 12:18:35]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 12:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 13:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 13:37:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kolos1, 2016-07-13 08:05:08]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-07-13 08:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:51:16]

Description was changed from

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was
generated, there is no check whether the forms still exists. It was introduced
to be sure Chrome saves the generated password. The disadvantage of it is that
we send a positive vote to the server even if the login was failed (the vote
says generation was successful). 

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving
of generated password (i.e. save generated password right after generation and
update it after every user input). 

Thus, we are sure that the generated password was saved. No need in the first CL
(https://codereview.chromium.org/1237543002). Let remove its code since it
distorts votes statistics. 

BUG=552420
==========

to

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was
generated, there is no check whether the forms still exists. It was introduced
to be sure Chrome saves the generated password. The disadvantage of it is that
we send a positive vote to the server even if the login was failed (the vote
says generation was successful). 

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving
of generated password (i.e. save generated password right after generation and
update it after every user input). 

Thus, we are sure that the generated password was saved. No need in the first CL
(https://codereview.chromium.org/1237543002). Let remove its code since it
distorts votes statistics. 

BUG=552420
==========

[commit-bot: I haz the power, 2016-07-13 08:51:17]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-07-13 08:51:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 08:53:48]

Description was changed from

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was
generated, there is no check whether the forms still exists. It was introduced
to be sure Chrome saves the generated password. The disadvantage of it is that
we send a positive vote to the server even if the login was failed (the vote
says generation was successful). 

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving
of generated password (i.e. save generated password right after generation and
update it after every user input). 

Thus, we are sure that the generated password was saved. No need in the first CL
(https://codereview.chromium.org/1237543002). Let remove its code since it
distorts votes statistics. 

BUG=552420
==========

to

==========
[Password Generation] Checks the existence of the signin/signup form even if the
password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was
generated, there is no check whether the forms still exists. It was introduced
to be sure Chrome saves the generated password. The disadvantage of it is that
we send a positive vote to the server even if the login was failed (the vote
says generation was successful).

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving
of generated password (i.e. save generated password right after generation and
update it after every user input).

Thus, we are sure that the generated password was saved. No need in the first CL
(https://codereview.chromium.org/1237543002). Let remove its code since it
distorts votes statistics.

BUG=552420

Committed: https://crrev.com/87a189f1566ce8cf72b77dac8cb54ec6bc4ab27c
Cr-Commit-Position: refs/heads/master@{#405093}
==========

[commit-bot: I haz the power, 2016-07-13 08:53:49]

Patchset 2 (id:??) landed as
https://crrev.com/87a189f1566ce8cf72b77dac8cb54ec6bc4ab27c
Cr-Commit-Position: refs/heads/master@{#405093}

[kolos1, 2016-07-15 15:39:38]

Patchset #3 (id:110001) has been deleted