Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2141513002: [Password Generation] Checks the existence of the form even if the password was generated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unittests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 28085c074415b104a4c83bb7840e8e3a69a6e64a..3783547769da317a37944c33b5d95df0ecad4256 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -635,19 +635,15 @@ void PasswordManager::OnPasswordFormsRendered(
provisional_save_manager_->pending_credentials().action,
all_visible_forms_[i].action)) {
provisional_save_manager_->LogSubmitFailed();
- // Generated passwords should always be saved, but we do want to
- // record that the submission normally would have failed for UMA.
- if (!provisional_save_manager_->has_generated_password()) {
- if (logger) {
- logger->LogPasswordForm(Logger::STRING_PASSWORD_FORM_REAPPEARED,
- all_visible_forms_[i]);
- logger->LogMessage(Logger::STRING_DECISION_DROP);
- }
- provisional_save_manager_.reset();
- // Clear all_visible_forms_ once we found the match.
- all_visible_forms_.clear();
- return;
+ if (logger) {
+ logger->LogPasswordForm(Logger::STRING_PASSWORD_FORM_REAPPEARED,
+ all_visible_forms_[i]);
+ logger->LogMessage(Logger::STRING_DECISION_DROP);
}
+ provisional_save_manager_.reset();
+ // Clear all_visible_forms_ once we found the match.
+ all_visible_forms_.clear();
+ return;
}
}
} else {
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698