Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2141493002: Add missing traces for Supplement<> classes (Closed)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dshwang, tzik, sof, eae+blinkwatch, chasej+watch_chromium.org, slimming-paint-reviews_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, nhiroki, cmumford, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, jsbell+idb_chromium.org, kinuko+fileapi, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing traces for Supplement<> classes This is a preparation for adding Supplement<>::m_host in https://codereview.chromium.org/2136473002/. BUG= Committed: https://crrev.com/e7cd15d1005034167fc1e29098d5602d6535546b Cr-Commit-Position: refs/heads/master@{#404909}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Total comments: 3

Patch Set 4 : temp #

Patch Set 5 : temp #

Patch Set 6 : temp #

Patch Set 7 : temp #

Patch Set 8 : temp #

Patch Set 9 : temp #

Patch Set 10 : temp #

Patch Set 11 : temp #

Patch Set 12 : temp #

Patch Set 13 : temp #

Patch Set 14 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -18 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerClients.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkerClients.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Supplementable.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 92 (49 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-11 04:42:26 UTC) #2
kouhei (in TOK)
lgtm
4 years, 5 months ago (2016-07-11 04:44:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/20001
4 years, 5 months ago (2016-07-11 04:45:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/231695)
4 years, 5 months ago (2016-07-11 04:58:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/20001
4 years, 5 months ago (2016-07-11 05:03:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/40001
4 years, 5 months ago (2016-07-11 05:03:54 UTC) #14
sof
https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h File third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h (right): https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h#newcode30 third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h:30: #include "core/frame/LocalFrame.h" why is this needed?
4 years, 5 months ago (2016-07-11 05:10:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/228448)
4 years, 5 months ago (2016-07-11 05:23:43 UTC) #18
haraken
https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h File third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h (right): https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h#newcode30 third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h:30: #include "core/frame/LocalFrame.h" On 2016/07/11 05:10:31, sof wrote: > why ...
4 years, 5 months ago (2016-07-11 05:39:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/60001
4 years, 5 months ago (2016-07-11 05:39:49 UTC) #22
sof
https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h File third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h (right): https://codereview.chromium.org/2141493002/diff/40001/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h#newcode30 third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h:30: #include "core/frame/LocalFrame.h" On 2016/07/11 05:39:13, haraken wrote: > On ...
4 years, 5 months ago (2016-07-11 05:58:14 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/218513)
4 years, 5 months ago (2016-07-11 06:47:49 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/60001
4 years, 5 months ago (2016-07-11 07:22:58 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/50321)
4 years, 5 months ago (2016-07-11 08:33:51 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/80001
4 years, 5 months ago (2016-07-11 08:53:24 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/228512)
4 years, 5 months ago (2016-07-11 09:14:56 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/120001
4 years, 5 months ago (2016-07-11 09:30:57 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/218585)
4 years, 5 months ago (2016-07-11 10:36:51 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/140001
4 years, 5 months ago (2016-07-11 11:47:44 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252931)
4 years, 5 months ago (2016-07-11 12:06:48 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/140001
4 years, 5 months ago (2016-07-11 12:13:02 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/218641)
4 years, 5 months ago (2016-07-11 12:40:06 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/160001
4 years, 5 months ago (2016-07-11 13:22:25 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/188557) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 13:35:01 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/180001
4 years, 5 months ago (2016-07-11 23:21:31 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/219067)
4 years, 5 months ago (2016-07-12 00:36:27 UTC) #58
haraken
It's hard to make the compile pass on win (because of the template trick that ...
4 years, 5 months ago (2016-07-12 01:40:06 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/220001
4 years, 5 months ago (2016-07-12 02:44:35 UTC) #62
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/229136) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 02:50:03 UTC) #64
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/240001
4 years, 5 months ago (2016-07-12 03:44:19 UTC) #67
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/51037)
4 years, 5 months ago (2016-07-12 05:06:38 UTC) #69
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/260001
4 years, 5 months ago (2016-07-12 05:14:38 UTC) #72
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/199617)
4 years, 5 months ago (2016-07-12 06:38:55 UTC) #74
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/260001
4 years, 5 months ago (2016-07-12 06:42:26 UTC) #76
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191025)
4 years, 5 months ago (2016-07-12 08:36:50 UTC) #78
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/260001
4 years, 5 months ago (2016-07-12 09:23:14 UTC) #80
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191205)
4 years, 5 months ago (2016-07-12 13:26:29 UTC) #82
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/260001
4 years, 5 months ago (2016-07-12 13:38:57 UTC) #84
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191371)
4 years, 5 months ago (2016-07-12 17:04:14 UTC) #86
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141493002/260001
4 years, 5 months ago (2016-07-13 00:05:01 UTC) #88
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 5 months ago (2016-07-13 02:24:57 UTC) #89
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:25:17 UTC) #90
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:27:48 UTC) #92
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/e7cd15d1005034167fc1e29098d5602d6535546b
Cr-Commit-Position: refs/heads/master@{#404909}

Powered by Google App Engine
This is Rietveld 408576698