Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h

Issue 2141493002: Add missing traces for Supplement<> classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, Google Inc. All rights reserved. 2 * Copyright (C) 2011, Google Inc. All rights reserved.
3 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 3 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND 14 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
15 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
17 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE 17 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
18 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 18 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
19 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 19 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
20 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 20 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
21 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 21 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
22 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 22 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
23 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH 23 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
24 * DAMAGE. 24 * DAMAGE.
25 */ 25 */
26 26
27 #ifndef NavigatorContentUtils_h 27 #ifndef NavigatorContentUtils_h
28 #define NavigatorContentUtils_h 28 #define NavigatorContentUtils_h
29 29
30 #include "core/frame/LocalFrame.h"
sof 2016/07/11 05:10:31 why is this needed?
haraken 2016/07/11 05:39:13 Fixed.
sof 2016/07/11 05:58:14 thanks (forgot to add lgtm previously...but done n
30 #include "modules/ModulesExport.h" 31 #include "modules/ModulesExport.h"
31 #include "modules/navigatorcontentutils/NavigatorContentUtilsClient.h" 32 #include "modules/navigatorcontentutils/NavigatorContentUtilsClient.h"
32 #include "platform/Supplementable.h" 33 #include "platform/Supplementable.h"
33 #include "platform/heap/Handle.h" 34 #include "platform/heap/Handle.h"
34 #include "wtf/text/WTFString.h" 35 #include "wtf/text/WTFString.h"
35 36
36 namespace blink { 37 namespace blink {
37 38
38 class ExceptionState; 39 class ExceptionState;
39 class LocalFrame;
40 class Navigator; 40 class Navigator;
41 41
42 class MODULES_EXPORT NavigatorContentUtils final : public GarbageCollectedFinali zed<NavigatorContentUtils>, public Supplement<LocalFrame> { 42 class MODULES_EXPORT NavigatorContentUtils final : public GarbageCollectedFinali zed<NavigatorContentUtils>, public Supplement<LocalFrame> {
43 USING_GARBAGE_COLLECTED_MIXIN(NavigatorContentUtils); 43 USING_GARBAGE_COLLECTED_MIXIN(NavigatorContentUtils);
44 public: 44 public:
45 virtual ~NavigatorContentUtils(); 45 virtual ~NavigatorContentUtils();
46 46
47 static NavigatorContentUtils* from(LocalFrame&); 47 static NavigatorContentUtils* from(LocalFrame&);
48 static const char* supplementName(); 48 static const char* supplementName();
49 49
50 static void registerProtocolHandler(Navigator&, const String& scheme, const String& url, const String& title, ExceptionState&); 50 static void registerProtocolHandler(Navigator&, const String& scheme, const String& url, const String& title, ExceptionState&);
51 static String isProtocolHandlerRegistered(Navigator&, const String& scheme, const String& url, ExceptionState&); 51 static String isProtocolHandlerRegistered(Navigator&, const String& scheme, const String& url, ExceptionState&);
52 static void unregisterProtocolHandler(Navigator&, const String& scheme, cons t String& url, ExceptionState&); 52 static void unregisterProtocolHandler(Navigator&, const String& scheme, cons t String& url, ExceptionState&);
53 53
54 static NavigatorContentUtils* create(NavigatorContentUtilsClient*); 54 static NavigatorContentUtils* create(NavigatorContentUtilsClient*);
55 55
56 DEFINE_INLINE_VIRTUAL_TRACE() 56 DECLARE_VIRTUAL_TRACE();
57 {
58 visitor->trace(m_client);
59 Supplement<LocalFrame>::trace(visitor);
60 }
61 57
62 void setClientForTest(NavigatorContentUtilsClient* client) { m_client = clie nt; } 58 void setClientForTest(NavigatorContentUtilsClient* client) { m_client = clie nt; }
63 59
64 private: 60 private:
65 explicit NavigatorContentUtils(NavigatorContentUtilsClient* client) 61 explicit NavigatorContentUtils(NavigatorContentUtilsClient* client)
66 : m_client(client) 62 : m_client(client)
67 { 63 {
68 } 64 }
69 65
70 NavigatorContentUtilsClient* client() { return m_client.get(); } 66 NavigatorContentUtilsClient* client() { return m_client.get(); }
71 67
72 Member<NavigatorContentUtilsClient> m_client; 68 Member<NavigatorContentUtilsClient> m_client;
73 }; 69 };
74 70
75 } // namespace blink 71 } // namespace blink
76 72
77 #endif // NavigatorContentUtils_h 73 #endif // NavigatorContentUtils_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698