Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 21414002: Fix inline-block baseline with overflow: <not visible> (Closed)

Created:
7 years, 4 months ago by cbiesinger
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix inline-block baseline with overflow: <not visible> They should align to the bottom of the margin box. The baseline of an 'inline-block' is the baseline of its last line box in the normal flow, unless it has either no in-flow line boxes or if its 'overflow' property has a computed value other than 'visible', in which case the baseline is the bottom margin edge. (http://www.w3.org/TR/CSS21/visudet.html#line-height) BUG=259083 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155341

Patch Set 1 #

Patch Set 2 : with .pngs for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -97 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/compositing/geometry/clipping-foreground.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/geometry/foreground-layer-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/inline-block/tricky-baseline.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/compositing/geometry/clipping-foreground-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/clip/overflow-border-radius-combinations-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/clip/overflow-border-radius-transformed-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/inline-block/tricky-baseline-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/linux/virtual/softwarecompositing/geometry/clipping-foreground-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/compositing/geometry/clipping-foreground-expected.txt View 1 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/platform/win/compositing/geometry/foreground-layer-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/compositing/geometry/repaint-foreground-layer-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/fast/clip/overflow-border-radius-combinations-expected.txt View 1 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.txt View 1 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/fast/clip/overflow-border-radius-transformed-expected.txt View 1 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/linebox-overflow-in-textarea-padding-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/win/fast/inline-block/tricky-baseline-expected.txt View 1 2 chunks +6 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/fast/overflow/line-clamp-expected.txt View 1 7 chunks +30 lines, -30 lines 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/geometry/foreground-layer-expected.png View 1 Binary file 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
cbiesinger
7 years, 4 months ago (2013-07-31 22:02:15 UTC) #1
ojan
lgtm
7 years, 4 months ago (2013-07-31 22:23:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/21414002/4001
7 years, 4 months ago (2013-07-31 22:23:43 UTC) #3
commit-bot: I haz the power
Can't process patch for file LayoutTests/platform/linux/virtual/softwarecompositing/geometry/clipping-foreground-expected.png. Binary file support is temporarilly disabled due to a ...
7 years, 4 months ago (2013-07-31 22:23:46 UTC) #4
cbiesinger
7 years, 4 months ago (2013-08-01 16:41:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r155341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698