third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h - Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp ('k') | third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h

index ba0226be023b0e5903a29a57d1e1abcc4f719f46..403b0b1045a92a5cde93f0de8c777908928b5554 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h

@@ -31,8 +31,10 @@ public:

// Needed because we have to release |m_reader| promptly.

EAGERLY_FINALIZE();

// |handle| cannot be null and cannot be locked.

+ // This function must be called with entering an appropriate V8 context.

BodyStreamBuffer(ScriptState*, std::unique_ptr<FetchDataConsumerHandle> /* handle */);

// |ReadableStreamOperations::isReadableStream(stream)| must hold.

+ // This function must be called with entering an appropriate V8 context.

BodyStreamBuffer(ScriptState*, ScriptValue stream);

ScriptValue stream();