third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp - Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h ('k') | third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

index a339b1ecd5c3102b53769531af7d2b6cc6702c4a..b21ff4fb44965729d1bd51f6a49de42359eabc0e 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

@@ -106,7 +106,6 @@ BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState, std::unique_ptr<Fet

, m_madeFromReadableStream(false)

{

if (RuntimeEnabledFeatures::responseBodyWithV8ExtraStreamEnabled()) {

- ScriptState::Scope scope(scriptState);

if (isTerminating(scriptState)) {

m_reader = nullptr;

m_handle = nullptr;

@@ -141,7 +140,6 @@ BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState, ScriptValue stream)

, m_scriptState(scriptState)

, m_madeFromReadableStream(true)

{

- ScriptState::Scope scope(scriptState);

DCHECK(RuntimeEnabledFeatures::responseBodyWithV8ExtraStreamEnabled());

DCHECK(ReadableStreamOperations::isReadableStream(scriptState, stream));

if (isTerminating(scriptState))

@@ -228,7 +226,6 @@ void BodyStreamBuffer::tee(BodyStreamBuffer** branch1, BodyStreamBuffer** branch

*branch2 = nullptr;

if (m_madeFromReadableStream) {

- ScriptState::Scope scope(m_scriptState.get());

ScriptValue stream1, stream2;

ReadableStreamOperations::tee(m_scriptState.get(), stream(), &stream1, &stream2);

*branch1 = new BodyStreamBuffer(m_scriptState.get(), stream1);