Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/RequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
index a264e1eb13af6e3f64d377b140e52cb401f04ddf..f06bc4f36625f19ae0705bf2b21f85945fa4addb 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
@@ -33,6 +33,7 @@ private:
TEST_F(ServiceWorkerRequestTest, FromString)
{
+ ScriptState::Scope scope(getScriptState());
TrackExceptionState exceptionState;
KURL url(ParsedURLString, "http://www.example.com/");
@@ -44,6 +45,7 @@ TEST_F(ServiceWorkerRequestTest, FromString)
TEST_F(ServiceWorkerRequestTest, FromRequest)
{
+ ScriptState::Scope scope(getScriptState());
TrackExceptionState exceptionState;
KURL url(ParsedURLString, "http://www.example.com/");
@@ -58,6 +60,7 @@ TEST_F(ServiceWorkerRequestTest, FromRequest)
TEST_F(ServiceWorkerRequestTest, FromAndToWebRequest)
{
+ ScriptState::Scope scope(getScriptState());
WebServiceWorkerRequest webRequest;
const KURL url(ParsedURLString, "http://www.example.com/");
@@ -112,6 +115,7 @@ TEST_F(ServiceWorkerRequestTest, FromAndToWebRequest)
TEST_F(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment)
{
+ ScriptState::Scope scope(getScriptState());
TrackExceptionState exceptionState;
String urlWithoutFragment = "http://www.example.com/";
String url = urlWithoutFragment + "#fragment";
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Request.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698