[Fetch API] Remove HandleScope to protect local handles

third_party/WebKit/Source/modules/fetch/RequestTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/Request.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/Document.h"
 #include "core/frame/Frame.h"
 #include "core/testing/DummyPageHolder.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/HashMap.h"
 #include "wtf/text/WTFString.h"
 #include <memory>
 
 namespace blink {
 namespace {
 
 class ServiceWorkerRequestTest : public ::testing::Test {
 public:
     ServiceWorkerRequestTest()
         : m_page(DummyPageHolder::create(IntSize(1, 1))) { }

[haraken, 2016/07/14 02:26:08]

Nit: It would be better to use V8TestingScope. (You don't need to fix in this
CL.)

[yhirano, 2016/07/14 04:45:32]

Done.

 
     ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->document().frame()); }
     ExecutionContext* getExecutionContext() { return getScriptState()->getExecutionContext(); }
 
 private:
     std::unique_ptr<DummyPageHolder> m_page;
 };
 
 TEST_F(ServiceWorkerRequestTest, FromString)
 {
+    ScriptState::Scope scope(getScriptState());
     TrackExceptionState exceptionState;
 
     KURL url(ParsedURLString, "http://www.example.com/");
     Request* request = Request::create(getScriptState(), url, exceptionState);
     ASSERT_FALSE(exceptionState.hadException());
     ASSERT(request);
     EXPECT_EQ(url, request->url());
 }
 
 TEST_F(ServiceWorkerRequestTest, FromRequest)
 {
+    ScriptState::Scope scope(getScriptState());
     TrackExceptionState exceptionState;
 
     KURL url(ParsedURLString, "http://www.example.com/");
     Request* request1 = Request::create(getScriptState(), url, exceptionState);
     ASSERT(request1);
 
     Request* request2 = Request::create(getScriptState(), request1, exceptionState);
     ASSERT_FALSE(exceptionState.hadException());
     ASSERT(request2);
     EXPECT_EQ(url, request2->url());
 }
 
 TEST_F(ServiceWorkerRequestTest, FromAndToWebRequest)
 {
+    ScriptState::Scope scope(getScriptState());
     WebServiceWorkerRequest webRequest;
 
     const KURL url(ParsedURLString, "http://www.example.com/");
     const String method = "GET";
     struct {
         const char* key;
         const char* value;
     } headers[] = { {"X-Foo", "bar"}, {"X-Quux", "foop"}, {0, 0} };
     const String referrer = "http://www.referrer.com/";
     const WebReferrerPolicy referrerPolicy = WebReferrerPolicyAlways;
@@ skipping 34 matching lines @@
     EXPECT_EQ(method, String(secondWebRequest.method()));
     EXPECT_EQ(context, secondWebRequest.requestContext());
     EXPECT_EQ(referrer, KURL(secondWebRequest.referrerUrl()));
     EXPECT_EQ(WebReferrerPolicyAlways, secondWebRequest.referrerPolicy());
     EXPECT_EQ(webRequest.headers(), secondWebRequest.headers());
     EXPECT_EQ(WebURLRequest::FetchRequestModeNoCORS, secondWebRequest.mode());
 }
 
 TEST_F(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment)
 {
+    ScriptState::Scope scope(getScriptState());
     TrackExceptionState exceptionState;
     String urlWithoutFragment = "http://www.example.com/";
     String url = urlWithoutFragment + "#fragment";
     Request* request = Request::create(getScriptState(), url, exceptionState);
     ASSERT(request);
 
     WebServiceWorkerRequest webRequest;
     request->populateWebServiceWorkerRequest(webRequest);
     EXPECT_EQ(urlWithoutFragment, KURL(webRequest.url()));
 }
 
 } // namespace
 } // namespace blink