Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2141293002: [Cast for ATV] Enable UMP on Cast for ATV (Closed)

Created:
4 years, 5 months ago by AndyWu
Modified:
4 years, 5 months ago
CC:
alokp+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast for ATV] Enable UMP on Cast for ATV 1. Enable unified media pepeline on Cast for ATV. 2. Add a commend parameter to force WMPI starting in fullscreen mode so that it would use SurfaceView instead of SurfaceTexture on Android. BUG=internal b/29463340 Committed: https://crrev.com/ee562e963c4fd7bdc4e885ee13050c97adfc9f3a Cr-Commit-Position: refs/heads/master@{#406615}

Patch Set 1 #

Total comments: 7

Patch Set 2 : [Cast for ATV] Enable UMP on Cast for ATV #

Total comments: 2

Patch Set 3 : [Cast for ATV] Enable UMP on Cast for ATV #

Patch Set 4 : [Cast for ATV] Enable UMP on Cast for ATV #

Total comments: 12

Patch Set 5 : Make changes per comments on PS 4 #

Patch Set 6 : fix typos #

Patch Set 7 : rebase #

Patch Set 8 : fix unit tests #

Patch Set 9 : fix unit tests #

Total comments: 1

Patch Set 10 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -30 lines) Patch
M build/config/features.gni View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/media_switches.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 2 3 4 5 6 3 chunks +11 lines, -5 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 6 7 8 9 10 chunks +40 lines, -19 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 52 (29 generated)
AndyWu
kForceMediaPlayerStartingInFullscreenMode will be turned on in chromecast internal code.
4 years, 5 months ago (2016-07-12 23:46:52 UTC) #4
Simeon
On 2016/07/12 23:46:52, AndyWu wrote: > kForceMediaPlayerStartingInFullscreenMode will be turned on in chromecast > internal ...
4 years, 5 months ago (2016-07-13 16:56:09 UTC) #5
liberato (no reviews please)
https://codereview.chromium.org/2141293002/diff/20001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2141293002/diff/20001/media/blink/webmediaplayer_impl.cc#newcode1334 media/blink/webmediaplayer_impl.cc:1334: enteredFullscreen(); what happens if blink really does enter / ...
4 years, 5 months ago (2016-07-14 16:26:59 UTC) #6
halliwell
https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni#newcode68 build/config/features.gni:68: enable_video_hole = false is android webview still using this? ...
4 years, 5 months ago (2016-07-14 16:37:36 UTC) #8
liberato (no reviews please)
+timav: can you comment feature.gni ? thanks -fl https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni#newcode68 build/config/features.gni:68: enable_video_hole ...
4 years, 5 months ago (2016-07-14 16:53:36 UTC) #10
Tima Vaisburd
https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni#newcode68 build/config/features.gni:68: enable_video_hole = false On 2016/07/14 16:53:36, liberato wrote: > ...
4 years, 5 months ago (2016-07-14 18:23:16 UTC) #12
AndyWu
https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni#newcode68 build/config/features.gni:68: enable_video_hole = false On 2016/07/14 18:23:16, Tima Vaisburd wrote: ...
4 years, 5 months ago (2016-07-14 19:02:09 UTC) #13
boliu
On 2016/07/14 19:02:09, AndyWu wrote: > https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni > File build/config/features.gni (right): > > https://codereview.chromium.org/2141293002/diff/1/build/config/features.gni#newcode68 > ...
4 years, 5 months ago (2016-07-14 20:06:17 UTC) #14
AndyWu
Please help to review patch set #4, thanks.
4 years, 5 months ago (2016-07-18 19:44:20 UTC) #15
watk
https://codereview.chromium.org/2141293002/diff/60001/media/base/media_switches.h File media/base/media_switches.h (right): https://codereview.chromium.org/2141293002/diff/60001/media/base/media_switches.h#newcode70 media/base/media_switches.h:70: MEDIA_EXPORT extern const char kForceMediaPlayerUsingOverlay[]; What about kForceVideoOverlays? https://codereview.chromium.org/2141293002/diff/60001/media/blink/webmediaplayer_impl.cc ...
4 years, 5 months ago (2016-07-18 20:03:02 UTC) #16
liberato (no reviews please)
https://codereview.chromium.org/2141293002/diff/60001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2141293002/diff/60001/media/blink/webmediaplayer_impl.cc#newcode299 media/blink/webmediaplayer_impl.cc:299: void WebMediaPlayerImpl::DisableOverlay() { DCHECK(overlay_enabled_) https://codereview.chromium.org/2141293002/diff/60001/media/blink/webmediaplayer_impl.cc#newcode1310 media/blink/webmediaplayer_impl.cc:1310: void WebMediaPlayerImpl::OnSurfaceCreated(int surface_id) ...
4 years, 5 months ago (2016-07-18 20:19:58 UTC) #17
AndyWu
https://codereview.chromium.org/2141293002/diff/60001/media/base/media_switches.h File media/base/media_switches.h (right): https://codereview.chromium.org/2141293002/diff/60001/media/base/media_switches.h#newcode70 media/base/media_switches.h:70: MEDIA_EXPORT extern const char kForceMediaPlayerUsingOverlay[]; On 2016/07/18 20:03:02, watk ...
4 years, 5 months ago (2016-07-18 22:21:50 UTC) #18
liberato (no reviews please)
lgtm
4 years, 5 months ago (2016-07-19 15:19:17 UTC) #19
DaleCurtis
switch is fine with me for testing purposes now though, lgtm https://codereview.chromium.org/2141293002/diff/160001/media/base/media_switches.h File media/base/media_switches.h (right): ...
4 years, 5 months ago (2016-07-19 18:47:59 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141293002/180001
4 years, 5 months ago (2016-07-19 22:36:55 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/220983)
4 years, 5 months ago (2016-07-19 22:46:26 UTC) #41
AndyWu
Hi Brett, please help to review build/config/features.gni. Hi Luke, please help to review chromecast/browser/cast_browser_main_parts.cc.
4 years, 5 months ago (2016-07-19 22:58:29 UTC) #43
halliwell
On 2016/07/19 22:58:29, AndyWu wrote: > Hi Brett, please help to review build/config/features.gni. > Hi ...
4 years, 5 months ago (2016-07-19 23:37:01 UTC) #44
brettw
lgtm
4 years, 5 months ago (2016-07-20 17:31:53 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141293002/180001
4 years, 5 months ago (2016-07-20 17:56:58 UTC) #47
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 5 months ago (2016-07-20 18:03:51 UTC) #49
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 18:03:59 UTC) #50
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:05:16 UTC) #52
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/ee562e963c4fd7bdc4e885ee13050c97adfc9f3a
Cr-Commit-Position: refs/heads/master@{#406615}

Powered by Google App Engine
This is Rietveld 408576698