build/config/features.gni - Issue 2141293002: [Cast for ATV] Enable UMP on Cast for ATV

Side by Side Diff: build/config/features.gni

Issue 2141293002: [Cast for ATV] Enable UMP on Cast for ATV (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chromecast/browser/cast_browser_main_parts.cc » ('j') | media/blink/webmediaplayer_impl.cc » ('J')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This file contains Chrome-feature-related build flags (see ui.gni for	5 # This file contains Chrome-feature-related build flags (see ui.gni for

6 # UI-related ones). These should theoretically be moved to the build files of	6 # UI-related ones). These should theoretically be moved to the build files of

7 # the features themselves.	7 # the features themselves.

8 #	8 #

9 # However, today we have many "bad" dependencies on some of these flags from,	9 # However, today we have many "bad" dependencies on some of these flags from,

10 # e.g. base, so they need to be global to match the GYP configuration. Also,	10 # e.g. base, so they need to be global to match the GYP configuration. Also,

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 enable_session_service = !is_android && !is_ios && !is_chromecast	57 enable_session_service = !is_android && !is_ios && !is_chromecast

58	58

59 enable_plugin_installation = is_win \|\| is_mac	59 enable_plugin_installation = is_win \|\| is_mac

60	60

61 enable_app_list = is_chromeos	61 enable_app_list = is_chromeos

62	62

63 enable_supervised_users = !is_ios && !is_chromecast	63 enable_supervised_users = !is_ios && !is_chromecast

64	64

65 enable_remoting = !is_ios && !is_chromecast	65 enable_remoting = !is_ios && !is_chromecast

66	66

67 # Enable hole punching for the protected video.	67 # Hole punching is deprecated.

68 enable_video_hole = is_android	68 enable_video_hole = false
	halliwell 2016/07/14 16:37:35 is android webview still using this? (a search fo is android webview still using this? (a search for VIDEO_HOLE suggests so?) i.e. should this condition use is_chromecast? liberato (no reviews please) 2016/07/14 16:53:36 +timav, but i believe that the answer recently bec Show quoted text On 2016/07/14 16:37:35, halliwell wrote: > is android webview still using this? (a search for VIDEO_HOLE suggests so?) > i.e. should this condition use is_chromecast? +timav, but i believe that the answer recently became 'no'. Tima Vaisburd 2016/07/14 18:23:16 WebView does not currently use VIDEO_HOLE. I think Show quoted text On 2016/07/14 16:53:36, liberato wrote: > On 2016/07/14 16:37:35, halliwell wrote: > > is android webview still using this? (a search for VIDEO_HOLE suggests so?) > > i.e. should this condition use is_chromecast? > > +timav, but i believe that the answer recently became 'no'. WebView does not currently use VIDEO_HOLE. I think it's ok to set it to false. Bo? AndyWu 2016/07/14 19:02:08 Just to be safe, I take the suggestion from halliw Show quoted text On 2016/07/14 18:23:16, Tima Vaisburd wrote: > On 2016/07/14 16:53:36, liberato wrote: > > On 2016/07/14 16:37:35, halliwell wrote: > > > is android webview still using this? (a search for VIDEO_HOLE suggests so?) > > > > i.e. should this condition use is_chromecast? > > > > +timav, but i believe that the answer recently became 'no'. > > WebView does not currently use VIDEO_HOLE. I think it's ok to set it to false. > Bo? Just to be safe, I take the suggestion from halliwell. We will remove this anyway once the hole punching is deprecated.
69	69

70 # Enables browser side Content Decryption Modules. Required for embedders	70 # Enables browser side Content Decryption Modules. Required for embedders

71 # (e.g. Android and ChromeCast) that use a browser side CDM.	71 # (e.g. Android and ChromeCast) that use a browser side CDM.

72 enable_browser_cdms = is_android \|\| is_chromecast	72 enable_browser_cdms = is_android \|\| is_chromecast

73	73

74 # Hangout services is an extension that adds extra features to Hangouts.	74 # Hangout services is an extension that adds extra features to Hangouts.

75 # For official GYP builds, this flag is set.	75 # For official GYP builds, this flag is set.

76 enable_hangout_services_extension = false	76 enable_hangout_services_extension = false

77	77

78 # Variable safe_browsing is used to control the build time configuration for	78 # Variable safe_browsing is used to control the build time configuration for

(...skipping 91 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
170 use_brlapi = is_chromeos	170 use_brlapi = is_chromeos

171	171

172 # Enable WebVR support by default on Android	172 # Enable WebVR support by default on Android

173 # Still requires command line flag to access API	173 # Still requires command line flag to access API

174 enable_webvr = is_android	174 enable_webvr = is_android

175	175

176 enable_configuration_policy = !is_ios	176 enable_configuration_policy = !is_ios

177	177

178 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build	178 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build

179 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build	179 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build

OLD	NEW