Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2141273002: Reland of DevTools: automatically populate 'More tools' submenu with the drawer views. (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: automatically populate 'More tools' submenu with the drawer views. (patchset #1 id:1 of https://codereview.chromium.org/2142303002/ ) Reason for revert: Was not the one responsible for the bot failures. Original issue's description: > Revert of DevTools: automatically populate 'More tools' submenu with the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) > > Reason for revert: > Possible compile failure on Linux ChromiumOS GN > > Original issue's description: > > DevTools: automatically populate 'More tools' submenu with the drawer views. > > > > NOTRY=true > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37 > > Cr-Commit-Position: refs/heads/master@{#404838} > > TBR=dgozman@chromium.org,pfeldman@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/07d2063bc853aebc485346bbe118f33d8b54d597 > Committed: https://crrev.com/df46eddf339c3c4651c033ed0ad5f3fb459beb3a > Cr-Original-Commit-Position: refs/heads/master@{#404845} > Cr-Commit-Position: refs/heads/master@{#404848} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -200 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 4 chunks +28 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/module.json View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/devicesView.css View 4 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/module.json View 1 chunk +7 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 2 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ActionRegistry.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 4 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 3 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nektarios
Created Reland of DevTools: automatically populate 'More tools' submenu with the drawer views.
4 years, 5 months ago (2016-07-12 22:55:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141273002/1
4 years, 5 months ago (2016-07-12 22:56:59 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:58:14 UTC) #5
Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js:
While running git rm
third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js;
  fatal: pathspec
'third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js' did not
match any files

Patch:  D   
third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js
Index: third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js
diff --git
a/third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js
b/third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js
deleted file mode 100644
index
05fdade17b097fcb0982f55e138ae4cdc013047a..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/devtools/front_end/devices/DevicesDialog.js
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @constructor
- */
-WebInspector.DevicesDialog = function()
-{
-}
-
-/**
- * @constructor
- * @implements {WebInspector.ActionDelegate}
- */
-WebInspector.DevicesDialog.ActionDelegate = function()
-{
-    /** @type {?WebInspector.DevicesView} */
-    this._view = null;
-}
-
-WebInspector.DevicesDialog.ActionDelegate.prototype = {
-    /**
-     * @override
-     * @param {!WebInspector.Context} context
-     * @param {string} actionId
-     * @return {boolean}
-     */
-    handleAction: function(context, actionId)
-    {
-        if (actionId === "devices.dialog.show") {
-            if (!this._view)
-                this._view = new WebInspector.DevicesView();
-
-            var dialog = new WebInspector.Dialog();
-            dialog.addCloseButton();
-            this._view.show(dialog.element);
-            dialog.setMaxSize(new Size(700, 500));
-            dialog.show();
-            return true;
-        }
-        return false;
-    }
-}

Powered by Google App Engine
This is Rietveld 408576698