Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2141223002: Revert of shutil recipe_module: port chromium_utils rmtree implementation. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of shutil recipe_module: port chromium_utils rmtree implementation. (patchset #2 id:20001 of https://codereview.chromium.org/2146523003/ ) Reason for revert: too scary as it is. Let's do behind a flag first. Original issue's description: > shutil recipe_module: port chromium_utils rmtree implementation. > > BUG=584783 > R=martiniss@chromium.org > > Committed: https://github.com/luci/recipes-py/commit/774c69370e740a8a5c85dce90f88a2bbd11911f5 TBR=martiniss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584783 Committed: https://github.com/luci/recipes-py/commit/c3683107b331a0f9f0392c0a376ecf8143b1e2ac

Patch Set 1 #

Patch Set 2 : how about this? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -118 lines) Patch
M recipe_modules/shutil/api.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M recipe_modules/shutil/example.expected/basic.json View 1 1 chunk +16 lines, -4 lines 0 comments Download
D recipe_modules/shutil/resources/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/shutil/resources/rmtree.py View 1 chunk +0 lines, -111 lines 0 comments Download
M recipe_modules/tempfile/example.expected/basic.json View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
Created Revert of shutil recipe_module: port chromium_utils rmtree implementation.
4 years, 5 months ago (2016-07-12 20:36:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141223002/1
4 years, 5 months ago (2016-07-12 20:36:12 UTC) #3
commit-bot: I haz the power
Failed to apply patch for recipe_modules/shutil/resources/__init__.py: While running git apply --index -3 -p1; fatal: unrecognized ...
4 years, 5 months ago (2016-07-12 20:36:17 UTC) #5
tandrii(chromium)
damn, but of course rietveld/CQ can't handle empty files. damn it.
4 years, 5 months ago (2016-07-12 20:36:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141223002/160001
4 years, 5 months ago (2016-07-12 20:38:01 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 20:38:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as
https://github.com/luci/recipes-py/commit/c3683107b331a0f9f0392c0a376ecf8143b...

Powered by Google App Engine
This is Rietveld 408576698