recipe_modules/shutil/example.expected/basic.json - Issue 2141223002: Revert of shutil recipe_module: port chromium_utils rmtree implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/shutil/example.expected/basic.json

Issue 2141223002: Revert of shutil recipe_module: port chromium_utils rmtree implementation. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/recipes-py@master

Patch Set: how about this? Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/shutil/example.expected/basic.json

diff --git a/recipe_modules/shutil/example.expected/basic.json b/recipe_modules/shutil/example.expected/basic.json

index 7369c8c6c74a0fcac394de024611886db14cd48d..c369d78ebb259af2e33b15cbd9015367e060c359 100644

--- a/recipe_modules/shutil/example.expected/basic.json

+++ b/recipe_modules/shutil/example.expected/basic.json

@@ -213,19 +213,31 @@

"cmd": [

"python",

"-u",

- "RECIPE_MODULE[recipe_engine::shutil]/resources/rmtree.py",

+ "\nimport shutil, sys\nshutil.rmtree(sys.argv[1])\n",

"[TMP_BASE]/copytree_example_tmp"

- "name": "cleanup"

+ "name": "cleanup",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import shutil, sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@shutil.rmtree(sys.argv[1])@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

{

"cmd": [

"python",

"-u",

- "RECIPE_MODULE[recipe_engine::shutil]/resources/rmtree.py",

+ "\nimport shutil, sys\nshutil.rmtree(sys.argv[1])\n",

"[TMP_BASE]/copytree_example_tmp2"

- "name": "cleanup2"

+ "name": "cleanup2",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import shutil, sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@shutil.rmtree(sys.argv[1])@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

{

"name": "$result",

« no previous file with comments | « recipe_modules/shutil/api.py ('k') | recipe_modules/shutil/resources/__init__.py » ('j') | no next file with comments »