Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2141093004: Remove one-callsite private function on TextFinder. (Closed)

Created:
4 years, 5 months ago by dglazkov
Modified:
4 years, 5 months ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove one-callsite private function on TextFinder. It's a one-liner, too. R=esprehn Committed: https://crrev.com/4098ab1eb021d986c03733d1c40e9dd980557330 Cr-Commit-Position: refs/heads/master@{#405203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/web/TextFinder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dglazkov
PTAL.
4 years, 5 months ago (2016-07-13 16:07:00 UTC) #9
esprehn
lgtm
4 years, 5 months ago (2016-07-13 17:01:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141093004/1
4 years, 5 months ago (2016-07-13 17:04:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:10:15 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:12:33 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4098ab1eb021d986c03733d1c40e9dd980557330
Cr-Commit-Position: refs/heads/master@{#405203}

Powered by Google App Engine
This is Rietveld 408576698