Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: third_party/WebKit/Source/web/TextFinder.h

Issue 2141093004: Remove one-callsite private function on TextFinder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // match index returned by nearestFindMatch. Returns the ordinal of the new 133 // match index returned by nearestFindMatch. Returns the ordinal of the new
134 // selected match or -1 in case of error. Also provides the bounding box of 134 // selected match or -1 in case of error. Also provides the bounding box of
135 // the marker in window coordinates if selectionRect is not null. 135 // the marker in window coordinates if selectionRect is not null.
136 int selectFindMatch(unsigned index, WebRect* selectionRect); 136 int selectFindMatch(unsigned index, WebRect* selectionRect);
137 137
138 // Compute and cache the rects for FindMatches if required. 138 // Compute and cache the rects for FindMatches if required.
139 // Rects are automatically invalidated in case of content size changes, 139 // Rects are automatically invalidated in case of content size changes,
140 // propagating the invalidation to child frames. 140 // propagating the invalidation to child frames.
141 void updateFindMatchRects(); 141 void updateFindMatchRects();
142 142
143 // Add a WebKit TextMatch-highlight marker to nodes in a range.
144 void addMarker(Range*, bool activeMatch);
145
146 // Sets the markers within a range as active or inactive. Returns true if at least 143 // Sets the markers within a range as active or inactive. Returns true if at least
147 // one such marker found. 144 // one such marker found.
148 bool setMarkerActive(Range*, bool active); 145 bool setMarkerActive(Range*, bool active);
149 146
150 // Removes all markers. 147 // Removes all markers.
151 void unmarkAllTextMatches(); 148 void unmarkAllTextMatches();
152 149
153 // Determines whether the scoping effort is required for a particular frame. 150 // Determines whether the scoping effort is required for a particular frame.
154 // It is not necessary if the frame is invisible, for example, or if this 151 // It is not necessary if the frame is invisible, for example, or if this
155 // is a repeat search that already returned nothing last time the same prefi x 152 // is a repeat search that already returned nothing last time the same prefi x
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 // Determines if the rects in the find-in-page matches cache of this frame 253 // Determines if the rects in the find-in-page matches cache of this frame
257 // are invalid and should be recomputed. 254 // are invalid and should be recomputed.
258 bool m_findMatchRectsAreValid; 255 bool m_findMatchRectsAreValid;
259 }; 256 };
260 257
261 } // namespace blink 258 } // namespace blink
262 259
263 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::TextFinder::FindMatch); 260 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::TextFinder::FindMatch);
264 261
265 #endif // TextFinder_h 262 #endif // TextFinder_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698