Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2141083002: Fix use of itertools.groupby when collecting origin trial members (Closed)

Created:
4 years, 5 months ago by iclelland
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use of itertools.groupby when collecting origin trial members BUG=626435 R=yukishiino@chromium.org, mek@chromium.org Committed: https://crrev.com/b055688290331fde1745712fcf303d2a72711e08 Cr-Commit-Position: refs/heads/master@{#405151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
iclelland
+r mek, this should address the issue you brought up in https://codereview.chromium.org/2130883002/ +r yuki as ...
4 years, 5 months ago (2016-07-12 15:23:27 UTC) #1
haraken
LGTM
4 years, 5 months ago (2016-07-12 15:27:11 UTC) #2
Marijn Kruisselbrink
lgtm
4 years, 5 months ago (2016-07-12 16:31:13 UTC) #4
Yuki
lgtm
4 years, 5 months ago (2016-07-13 05:41:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141083002/1
4 years, 5 months ago (2016-07-13 13:47:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:04:07 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:04:17 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:05:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b055688290331fde1745712fcf303d2a72711e08
Cr-Commit-Position: refs/heads/master@{#405151}

Powered by Google App Engine
This is Rietveld 408576698