third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2141083002: Fix use of itertools.groupby when collecting origin trial members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2141083002: Fix use of itertools.groupby when collecting origin trial members (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index f2b579de884c0231840db9f0a5db30e29fe19174..848ef266c6d927760bd1cf7c707eedc4ac602890 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -116,7 +116,9 @@ def origin_trial_features(interface, constants, attributes, methods):

method['origin_trial_feature_name'])]

)

# Group members by origin_trial_feature_name

- members_by_name = itertools.groupby(origin_trial_members, itemgetter('origin_trial_feature_name'))

+ members_by_name = itertools.groupby(sorted(origin_trial_members,

+ key=itemgetter('origin_trial_feature_name')),

+ itemgetter('origin_trial_feature_name'))

# Construct the list of dictionaries. 'needs_instance' will be true if any

# member for the feature has 'on_instance' defined as true.

features = [{'name': name,

« no previous file with comments | « no previous file | no next file » | no next file with comments »