Mac a11y: Add Help, TopLevelUIElement, and Window accessibility attributes.

ui/views/widget/native_widget_mac_accessibility_unittest.mm

Index: ui/views/widget/native_widget_mac_accessibility_unittest.mm
diff --git a/ui/views/widget/native_widget_mac_accessibility_unittest.mm b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
index 1b37e4bcd9d3a921159c6615337e12ad66a1cba6..b117cfa1283a87112a5c34d30bcd6392c936f37b 100644
--- a/ui/views/widget/native_widget_mac_accessibility_unittest.mm
+++ b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
@@ -14,6 +14,7 @@
 #import "ui/accessibility/platform/ax_platform_node_mac.h"
 #include "ui/base/ime/text_input_type.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
+#include "ui/views/controls/label.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/widget.h"
@@ -168,6 +169,29 @@ TEST_F(NativeWidgetMacAccessibilityTest, PositionAttribute) {
               AttributeValueAtMidpoint(NSAccessibilityPositionAttribute));
 }
 
+// Test for NSAccessibilityHelpAttribute.
+TEST_F(NativeWidgetMacAccessibilityTest, HelpAttribute) {
+  Label* label = new Label(base::SysNSStringToUTF16(kTestPlaceholderText));
+  label->SetSize(GetWidgetBounds().size());
+  EXPECT_NSEQ(nil, AttributeValueAtMidpoint(NSAccessibilityHelpAttribute));
+  label->SetTooltipText(base::SysNSStringToUTF16(kTestPlaceholderText));
+  widget()->GetContentsView()->AddChildView(label);
+  EXPECT_NSEQ(kTestPlaceholderText,
+              AttributeValueAtMidpoint(NSAccessibilityHelpAttribute));
+}
+
+// Test for NSAccessibilityWindowAttribute and
+// NSAccessibilityTopLevelUIElementAttribute.
+TEST_F(NativeWidgetMacAccessibilityTest, WindowAndTopLevelUIElementAttributes) {
+  FlexibleRoleTestView* view = new FlexibleRoleTestView(ui::AX_ROLE_GROUP);
+  widget()->GetContentsView()->AddChildView(view);

[tapted, 2016/07/18 03:38:49]

will this be sized correctly to hit the view? (maybe first check some other
property at AttributeValueAtMidpoint that could only apply to the label and not
the window itself, to ensure it's the label being hit)

[Patti Lor, 2016/07/19 01:14:10]

You're right, I forgot to size it! Have added this in along with a test for the
AX_ROLE_GROUP set in the construction of |view|.

+  EXPECT_NSEQ(widget()->GetNativeWindow(),
+              AttributeValueAtMidpoint(NSAccessibilityWindowAttribute));
+  EXPECT_NSEQ(
+      widget()->GetNativeWindow(),
+      AttributeValueAtMidpoint(NSAccessibilityTopLevelUIElementAttribute));
+}
+
 // Tests for accessibility attributes on a views::Textfield.
 // TODO(patricialor): Test against Cocoa-provided attributes as well to ensure
 // consistency between Cocoa and toolkit-views.