Mac a11y: Add Help, TopLevelUIElement, and Window accessibility attributes.

ui/views/accessibility/native_view_accessibility.cc

Index: ui/views/accessibility/native_view_accessibility.cc
diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc
index 0cdec0d150397aec2813046df89fb1e840bc32c4..bea77a1011b3036d5ca2691c81cd594bb2e447fe 100644
--- a/ui/views/accessibility/native_view_accessibility.cc
+++ b/ui/views/accessibility/native_view_accessibility.cc
@@ -8,6 +8,7 @@
 #include "build/build_config.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event_utils.h"
+#include "ui/gfx/native_widget_types.h"
 #include "ui/views/controls/native/native_view_host.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
@@ -65,6 +66,11 @@ const ui::AXNodeData& NativeViewAccessibility::GetData() {
                            base::UTF16ToUTF8(state.keyboard_shortcut));
   data_.AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,
                            base::UTF16ToUTF8(state.placeholder));
+
+  if (view_->GetTooltipText(gfx::Point(), &state.help_text))

[tapted, 2016/07/18 03:38:48]

passing gfx::Point() might not work for the bookmarks bar or task manager
(tableview), but I think this is OK - they only use tooltips for truncated
strings, so there so there should be a better field already

[Patti Lor, 2016/07/19 01:14:10]

Have double checked this and you are right - both have their accessibilityTitle
set to the full text. I'm not sure if the truncating applies though - I see
elided text in the tooltip for bookmark buttons but the accessibilityHelp is
also the full string (same as accessibilityTitle). The task manager rows on the
other hand don't have tooltips at all (but their accessibilityTitle is set).

Either way it should be fine :)

[tapted, 2016/07/19 03:22:50]

Acknowledged. Yeah I only had a skim of the bookmarks bar / tableview code since
they make use of the |point| argument, but I'm not sure how the a11y hit test
will map - probably fine for a follow-up if we find an error

[Patti Lor, 2016/07/19 05:29:24]

I checked this using the XCode Accessibility Inspector, so hit tests for task
manager rows are fine. But I had to dig around a bit for the bookmark bar
buttons, but I think that will be fixed when http://crbug.com/610589 (hiding
labels inside LabelButtons from the a11y tree) is fixed.

+    data_.AddStringAttribute(ui::AX_ATTR_HELP_TEXT,
+                             base::UTF16ToUTF8(state.help_text));
+
   data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, state.selection_start);
   data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, state.selection_end);
 
@@ -105,6 +111,10 @@ gfx::NativeViewAccessible NativeViewAccessibility::ChildAtIndex(int index) {
   return nullptr;
 }
 
+gfx::NativeWindow NativeViewAccessibility::GetTopLevelWidget() {
+  return view_->GetWidget()->GetTopLevelWidget()->GetNativeWindow();

[tapted, 2016/07/19 03:22:50]

oops - I thought I'd written a comment here but I might have gotten distracted
by GetParent(). I think this should check `view_->GetWidget()` first to ensure
it's non-null (like GetParent does)

[Patti Lor, 2016/07/19 05:29:24]

Done, thank you.

+}
+
 gfx::NativeViewAccessible NativeViewAccessibility::GetParent() {
   if (view_->parent())
     return view_->parent()->GetNativeViewAccessible();