Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2140983003: Early out for inactive documents in FrameView lifecycle updating functions (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early out for inactive documents in FrameView lifecycle updating functions We may trigger lifecycle update while some documents in the frame tree are inactive. This looks valid and the functions should early out. BUG=626675 Committed: https://crrev.com/ae1eca83691c3167b4ea176e3ac8ba8392b03677 Cr-Commit-Position: refs/heads/master@{#405334}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
4 years, 5 months ago (2016-07-13 01:15:46 UTC) #2
szager1
lgtm
4 years, 5 months ago (2016-07-13 20:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140983003/40001
4 years, 5 months ago (2016-07-13 20:53:10 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 22:58:03 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:01:09 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae1eca83691c3167b4ea176e3ac8ba8392b03677
Cr-Commit-Position: refs/heads/master@{#405334}

Powered by Google App Engine
This is Rietveld 408576698