Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: third_party/WebKit/Source/core/paint/FramePainter.cpp

Issue 2140983003: Early out for inactive documents in FrameView lifecycle updating functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/FramePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/FramePainter.cpp b/third_party/WebKit/Source/core/paint/FramePainter.cpp
index de5bcce7099c055250e5c803659230b1c3188578..8ec3b8e4f5b63f30dd0bee718cf2ad45e2c52096 100644
--- a/third_party/WebKit/Source/core/paint/FramePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/FramePainter.cpp
@@ -95,7 +95,7 @@ void FramePainter::paintContents(GraphicsContext& context, const GlobalPaintFlag
{
Document* document = frameView().frame().document();
- if (frameView().shouldThrottleRendering())
+ if (frameView().shouldThrottleRendering() || !document->isActive())
return;
#ifndef NDEBUG
@@ -124,6 +124,8 @@ void FramePainter::paintContents(GraphicsContext& context, const GlobalPaintFlag
}
frameView().checkDoesNotNeedLayout();
+ // TODO(wangxianzhu): The following check should be stricter, but currently this is blocked
+ // by the svg root issue (crbug.com/442939).
ASSERT(document->lifecycle().state() >= DocumentLifecycle::CompositingClean);
TRACE_EVENT1("devtools.timeline", "Paint", "data", InspectorPaintEvent::data(layoutView, LayoutRect(rect), 0));
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698