Add PopularUrls test for Chrome using telemetry correctness test framework.

Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=604882
Committed: https://crrev.com/f6ad04c6319183cc6b04186f3a801a1241c8fbbc
Cr-Commit-Position: refs/heads/master@{#407609}

[mikecase (-- gone --), 2016-07-11 22:21:53]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2016-07-11 22:21:53]

No idea where I should put this test. But I implemented the PopularUrls test
with the telemetry correctness framework thingy like Ned advised I should.

I landed a CL last week so you can now start up webpage replay server for the
SeriallyExecutedBrowserTestCase's which this test uses.

This test is to replace the PopularUrls page_cycler test that was deleted a
couple months back because it was a host driven test.

[mikecase (-- gone --), 2016-07-11 22:22:57]

Description was changed from

==========
Add PopularUrls test for Chrome using telemetry test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=
==========

to

==========
Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=
==========

[mikecase (-- gone --), 2016-07-11 22:25:15]

This is a rewrite of https://codereview.chromium.org/1912443002 which was just a
telemetry test.

As Ned advised, I rewrote it using SeriallyExecutedBrowserTestCase because it is
not measuring metrics. It is just cycling thru pages.

[jbudorick, 2016-07-11 22:47:38]

I'm ok with this location (especially in light of e.g.
//content/test/gpu/gpu_tests) but would prefer someone else give the OK on that.

- please add a crbug
- please use 2-line breaks between functions etc at module scope
- if you're adding a directory that contains python, set up the linter

https://codereview.chromium.org/2140803003/diff/20001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/popular_urls.py (right):

https://codereview.chromium.org/2140803003/diff/20001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/popular_urls.py:154:
cls.StopWPRServer()
Do you need to stop the browser?

[mikecase (-- gone --), 2016-07-21 19:47:17]

Description was changed from

==========
Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=
==========

to

==========
Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=604882
==========

[mikecase (-- gone --), 2016-07-21 21:30:09]

- Added a PRESUBMIT.py file that runs a linter. Stole the pylintrc from
build/android. It caught some lint errors so Im pretty sure it is set up
correctly.

- Fixed line breaks

- Added crbug

- As I mentioned in a comment, the parent class will call StopBrowser for you.

https://codereview.chromium.org/2140803003/diff/20001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/popular_urls.py (right):

https://codereview.chromium.org/2140803003/diff/20001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/popular_urls.py:154:
cls.StopWPRServer()
On 2016/07/11 at 22:47:38, jbudorick wrote:
> Do you need to stop the browser?

No, the super class does that for you...

From SeriallyExecutedBrowserTestCase........

  @classmethod
  def tearDownClass(cls):
    if cls.platform:
      cls.platform.StopAllLocalServers()
    if cls.browser:
      cls.StopBrowser()

[mikecase (-- gone --), 2016-07-25 16:52:55]

ping

[jbudorick, 2016-07-25 18:17:59]

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/.gitignore (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/.gitignore:1: *.wpr
Why is this here rather than in //.gitignore?

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/popular_urls.py (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/popular_urls.py:132: # pylint:
disable=unused-argument
I think this disabled unused-argument for the rest of the class, not just for
GenerateTestCases_PageLoadTest. You could do the latter with either:

  def GenerateTestCases_PageLoadTest(cls, options): # pylint:
disable=unused-argument
    ...

or

  def GenerateTestCases_PageLoadTest(cls, options):
    # pylint: disable=unused-argument

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/pylintrc (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/pylintrc:1: [FORMAT]
Steal the one from blimp/tools/, this one has too many disabled messages.

[mikecase (-- gone --), 2016-07-25 20:57:08]

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/.gitignore (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/.gitignore:1: *.wpr
On 2016/07/25 at 18:17:59, jbudorick wrote:
> Why is this here rather than in //.gitignore?

No reason I guess. Moving.

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/browser_tests/popular_urls.py (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/browser_tests/popular_urls.py:132: # pylint:
disable=unused-argument
On 2016/07/25 at 18:17:59, jbudorick wrote:
> I think this disabled unused-argument for the rest of the class, not just for
GenerateTestCases_PageLoadTest. You could do the latter with either:
> 
>   def GenerateTestCases_PageLoadTest(cls, options): # pylint:
disable=unused-argument
>     ...
> 
> or
> 
>   def GenerateTestCases_PageLoadTest(cls, options):
>     # pylint: disable=unused-argument

Done. Thanks for the catch. Didnt know it worked that way.

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
File chrome/test/android/telemetry_tests/pylintrc (right):

https://codereview.chromium.org/2140803003/diff/60001/chrome/test/android/tel...
chrome/test/android/telemetry_tests/pylintrc:1: [FORMAT]
On 2016/07/25 at 18:17:59, jbudorick wrote:
> Steal the one from blimp/tools/, this one has too many disabled messages.

Done. Also fixed a bunch more lint errors that appeared after I did this.

[jbudorick, 2016-07-25 21:18:55]

lgtm

[mikecase (-- gone --), 2016-07-25 21:20:18]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:01:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-25 22:04:26]

Description was changed from

==========
Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=604882
==========

to

==========
Add PopularUrls test for Chrome using telemetry correctness test framework.

Running "run_chrome_browser_tests.py PopularUrlsTest" will run
a page cycler that loops through a list of popular urls. This test
is to replace the old PopularUrls test which was deleted because
it relied on some flaky build/android/test_runner.py code.

BUG=604882

Committed: https://crrev.com/f6ad04c6319183cc6b04186f3a801a1241c8fbbc
Cr-Commit-Position: refs/heads/master@{#407609}
==========

[commit-bot: I haz the power, 2016-07-25 22:04:28]

Patchset 5 (id:??) landed as
https://crrev.com/f6ad04c6319183cc6b04186f3a801a1241c8fbbc
Cr-Commit-Position: refs/heads/master@{#407609}