Reimplement basic PopularUrls page cycler in telemetry.

Reimplement basic PopularUrls page cycler in telemetry.

We had a popular urls test that ran on several of the
downstream bots. This test needs to be reimplemented
now that the host driven test framework it used has been
removed from Chromium. Implementing its base functionality
here, but will need to add more such as ability to take
screenshots and upload those screenshots to ISpy
appengine project in the future.

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

[mikecase (-- gone --), 2016-04-20 22:01:01]

Description was changed from

==========
Reimplement basic PopularUrls page cycler in telemetry.

We had a popular urls test that ran on several of the
downstream bots. This test needs to be reimplemented
now that the host driven test framework it used has been
removed from Chromium. Implementing its base functionality
here, but will need to add more such as ability to take
screenshots and upload those screenshots to ISpy
appengine project in the future.

BUG=
==========

to

==========
Reimplement basic PopularUrls page cycler in telemetry.

We had a popular urls test that ran on several of the
downstream bots. This test needs to be reimplemented
now that the host driven test framework it used has been
removed from Chromium. Implementing its base functionality
here, but will need to add more such as ability to take
screenshots and upload those screenshots to ISpy
appengine project in the future.

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[mikecase (-- gone --), 2016-04-20 22:04:08]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, rnephew@chromium.org

[mikecase (-- gone --), 2016-04-20 22:04:08]

I don't know if you guys had any opinions on this. Want to add add a page cycler
that is very
similar to the previous popular_urls test. I was thinking of just adding the
same exact list of
URLs that is currently cycled through. This would involve recording a WPR file
on the listed
500 urls before landing this CL. Alternatively, I could use the already existing
(and from
what I can tell completely unused) tools/perf/data/top_1000_mobile.json that was
recorded
several years ago.

[jbudorick, 2016-04-20 22:32:45]

uh, wow, this is much better than before.

not sure that we want/need more than the first 115, though, which is what we
were actually running before.

https://codereview.chromium.org/1912443002/diff/1/tools/perf/page_sets/key_mo...
File tools/perf/page_sets/key_mobile_sites.py (left):

https://codereview.chromium.org/1912443002/diff/1/tools/perf/page_sets/key_mo...
tools/perf/page_sets/key_mobile_sites.py:19: self.archive_data_file =
'data/key_mobile_sites.json'
?

[mikecase (-- gone --), 2016-04-28 20:49:52]

ok, recorded a wpr for the popular urls with help from Randy.

Can run the new popular urls page cyclers like...

./run_benchmark run page_cycler.popular_urls --also-run-disabled-tests

or to use live sites...
./run_benchmark run page_cycler.popular_urls --also-run-disabled-tests
--use-live-sites

I uploaded the wpr to the telemetry PARTNER_BUCKET so I think the bots should be
able to find it.

https://codereview.chromium.org/1912443002/diff/1/tools/perf/page_sets/key_mo...
File tools/perf/page_sets/key_mobile_sites.py (left):

https://codereview.chromium.org/1912443002/diff/1/tools/perf/page_sets/key_mo...
tools/perf/page_sets/key_mobile_sites.py:19: self.archive_data_file =
'data/key_mobile_sites.json'
On 2016/04/20 at 22:32:45, jbudorick wrote:
> ?

this is just an unused field. I cleaned a bunch of them up in a previous CL but
I guess missed this one. Page objects dont use archive_data_file anymore.

[mikecase (-- gone --), 2016-05-02 17:39:34]

mikecase@chromium.org changed reviewers:
+ nednguyen@google.com

[mikecase (-- gone --), 2016-05-02 17:39:35]

ping

[jbudorick, 2016-05-02 17:46:13]

This seems mostly fine to me, but Ned and Randy are both more familiar with this
than I am.

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
File tools/perf/page_sets/key_mobile_sites.py (left):

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
tools/perf/page_sets/key_mobile_sites.py:19: self.archive_data_file =
'data/key_mobile_sites.json'
?

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
File tools/perf/page_sets/popular_urls.py (right):

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
tools/perf/page_sets/popular_urls.py:18: urls_list = [
nit: I_AM_A_MODULE_SCOPE_CONSTANT

also, I'd prefer this be above PopularUrlsPage

[rnephew (Reviews Here), 2016-05-02 18:01:08]

On 2016/05/02 17:46:13, jbudorick wrote:
> This seems mostly fine to me, but Ned and Randy are both more familiar with
this
> than I am.
> 
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
> File tools/perf/page_sets/key_mobile_sites.py (left):
> 
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
> tools/perf/page_sets/key_mobile_sites.py:19: self.archive_data_file =
> 'data/key_mobile_sites.json'
> ?
> 
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
> File tools/perf/page_sets/popular_urls.py (right):
> 
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
> tools/perf/page_sets/popular_urls.py:18: urls_list = [
> nit: I_AM_A_MODULE_SCOPE_CONSTANT
> 
> also, I'd prefer this be above PopularUrlsPage

non-owner lgtm

[rnephew (Reviews Here), 2016-05-02 18:01:25]

On 2016/05/02 18:01:08, rnephew1 wrote:
> On 2016/05/02 17:46:13, jbudorick wrote:
> > This seems mostly fine to me, but Ned and Randy are both more familiar with
> this
> > than I am.
> > 
> >
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
> > File tools/perf/page_sets/key_mobile_sites.py (left):
> > 
> >
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/ke...
> > tools/perf/page_sets/key_mobile_sites.py:19: self.archive_data_file =
> > 'data/key_mobile_sites.json'
> > ?
> > 
> >
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
> > File tools/perf/page_sets/popular_urls.py (right):
> > 
> >
>
https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
> > tools/perf/page_sets/popular_urls.py:18: urls_list = [
> > nit: I_AM_A_MODULE_SCOPE_CONSTANT
> > 
> > also, I'd prefer this be above PopularUrlsPage
> 
> non-owner lgtm

non-owner lgtm with johns comment*

[rnephew (Reviews Here), 2016-05-02 18:02:52]

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:234: 
nit: 2 lines.

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
File tools/perf/page_sets/popular_urls.py (right):

https://codereview.chromium.org/1912443002/diff/20001/tools/perf/page_sets/po...
tools/perf/page_sets/popular_urls.py:128: 
nit: 2 lines.

[nednguyen, 2016-05-02 19:14:01]

nednguyen@google.com changed reviewers:
+ kouhei@chromium.org

[nednguyen, 2016-05-02 19:14:01]

+kouhei

[nednguyen(REVIEW IN OTHER ACC), 2016-05-02 22:14:24]

On 2016/05/02 19:14:01, nednguyen (ooo til 5-4) wrote:
> +kouhei

Hmhh, why do you use telemetry benchmarking to migrate this to? Shouldn't you
use the browser_integration_test framework instead?

[mikecase (-- gone --), 2016-05-09 17:05:11]

On 2016/05/02 at 22:14:24, nednguyen wrote:
> On 2016/05/02 19:14:01, nednguyen (ooo til 5-4) wrote:
> > +kouhei
> 
> Hmhh, why do you use telemetry benchmarking to migrate this to? Shouldn't you
use the browser_integration_test framework instead?

By browser_integration_test framework are you referring to tests like this.... ?
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu...

If so, can the test runner for these tests set up WebPageReplay? I'm slightly
unclear about the differences between these tests and normal telemetry tests in
how they are run.

[nednguyen, 2016-05-09 17:33:13]

On 2016/05/09 17:05:11, mikecase wrote:
> On 2016/05/02 at 22:14:24, nednguyen wrote:
> > On 2016/05/02 19:14:01, nednguyen (ooo til 5-4) wrote:
> > > +kouhei
> > 
> > Hmhh, why do you use telemetry benchmarking to migrate this to? Shouldn't
you
> use the browser_integration_test framework instead?
> 
> By browser_integration_test framework are you referring to tests like this....
?
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu...
> 
> If so, can the test runner for these tests set up WebPageReplay? 

It's possible, but we have to set up the wpr_server in setUp & tearDown
(perezju@ can show you how)

> I'm slightly
> unclear about the differences between these tests and normal telemetry tests
in
> how they are run.

The normal temeletry tests are technically not "tests", they are benchmark.
Hence their purpose is to simulate the user actions & compute some performance
metrics.

For this case, it seems to me you just want to know whether these runs are
passing/failing, hence should be using SeriallyBrowserTestCase structure
instead. It's much easier to set up for your case.

[nednguyen, 2016-05-09 17:33:27]

Description was changed from

==========
Reimplement basic PopularUrls page cycler in telemetry.

We had a popular urls test that ran on several of the
downstream bots. This test needs to be reimplemented
now that the host driven test framework it used has been
removed from Chromium. Implementing its base functionality
here, but will need to add more such as ability to take
screenshots and upload those screenshots to ISpy
appengine project in the future.

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Reimplement basic PopularUrls page cycler in telemetry.

We had a popular urls test that ran on several of the
downstream bots. This test needs to be reimplemented
now that the host driven test framework it used has been
removed from Chromium. Implementing its base functionality
here, but will need to add more such as ability to take
screenshots and upload those screenshots to ISpy
appengine project in the future.

BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[nednguyen, 2016-05-09 17:33:27]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org
- kouhei@chromium.org