Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2140793002: Add the content_shell_syzyasan GN target. (Closed)

Created:
4 years, 5 months ago by Sébastien Marchand
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the content_shell_syzyasan GN target. BUG=619086 Committed: https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f Cr-Commit-Position: refs/heads/master@{#405161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2126673002 Patch 120001

Messages

Total messages: 22 (9 generated)
Sébastien Marchand
PTAL.
4 years, 5 months ago (2016-07-11 20:14:37 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-11 20:59:48 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-12 15:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140793002/1
4 years, 5 months ago (2016-07-12 15:13:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242624)
4 years, 5 months ago (2016-07-12 16:47:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140793002/1
4 years, 5 months ago (2016-07-12 18:36:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/200162)
4 years, 5 months ago (2016-07-12 21:07:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140793002/1
4 years, 5 months ago (2016-07-12 21:25:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261410)
4 years, 5 months ago (2016-07-13 00:30:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140793002/1
4 years, 5 months ago (2016-07-13 15:00:00 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:35:21 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:35:42 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:38:22 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f
Cr-Commit-Position: refs/heads/master@{#405161}

Powered by Google App Engine
This is Rietveld 408576698