Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2126673002: Move the Syzygy scripts out of //chrome/ (Closed)

Created:
4 years, 5 months ago by Sébastien Marchand
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, gab, chrisha
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, grt+watch_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the Syzygy scripts out of //chrome/ Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome). BUG=619086 Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758 Committed: https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab Cr-Original-Commit-Position: refs/heads/master@{#404503} Cr-Commit-Position: refs/heads/master@{#404672}

Patch Set 1 #

Patch Set 2 : Move the Syzygy scripts out of //chrome/ #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : Fix the GYP files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -462 lines) Patch
M BUILD.gn View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
A build/win/syzygy/BUILD.gn View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A + build/win/syzygy/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A + build/win/syzygy/instrument.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + build/win/syzygy/reorder.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + build/win/syzygy/syzyasan-allocation-filter.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/win/syzygy/syzyasan-instrumentation-filter.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A build/win/syzygy/syzygy.gni View 1 1 chunk +137 lines, -0 lines 0 comments Download
M chrome/chrome_syzygy.gypi View 1 2 3 4 5 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/syzygy/BUILD.gn View 1 2 3 4 6 chunks +9 lines, -155 lines 0 comments Download
D chrome/tools/build/win/syzygy/instrument.py View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/tools/build/win/syzygy/reorder.py View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/tools/build/win/syzygy/syzyasan-instrumentation-filter.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/kasko/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (13 generated)
Sébastien Marchand
PTAL ?
4 years, 5 months ago (2016-07-06 20:15:25 UTC) #3
chrisha
lgtm!
4 years, 5 months ago (2016-07-08 14:07:56 UTC) #4
chrisha
(Note: That's a rs-lgtm for pretty much all actual GN contents. I don't speak much ...
4 years, 5 months ago (2016-07-08 14:08:26 UTC) #5
Sébastien Marchand
+dpranke@ for the GN code and for owner approval of everything in build/, PTAL.
4 years, 5 months ago (2016-07-08 14:33:22 UTC) #7
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-08 19:41:42 UTC) #8
Sébastien Marchand
+gab for owner approval of chrome/installer/mini_installer/BUILD.gn (one line change)
4 years, 5 months ago (2016-07-08 19:44:05 UTC) #10
gab
On 2016/07/08 19:44:05, Sébastien Marchand wrote: > +gab for owner approval of chrome/installer/mini_installer/BUILD.gn (one line ...
4 years, 5 months ago (2016-07-08 20:35:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126673002/80001
4 years, 5 months ago (2016-07-08 20:37:06 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-08 22:03:50 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 22:04:12 UTC) #16
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758 Cr-Commit-Position: refs/heads/master@{#404503}
4 years, 5 months ago (2016-07-08 22:05:02 UTC) #18
Sébastien Marchand
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2129333002/ by sebmarchand@chromium.org. ...
4 years, 5 months ago (2016-07-08 23:25:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126673002/120001
4 years, 5 months ago (2016-07-11 15:27:37 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 5 months ago (2016-07-11 16:33:35 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 16:34:48 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab
Cr-Commit-Position: refs/heads/master@{#404672}

Powered by Google App Engine
This is Rietveld 408576698