DevTools: remove BaseToolbarPaneWidget.

DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/8a80cbeaa2a3e3fd036022678518871273dc9a46
Cr-Commit-Position: refs/heads/master@{#404840}

[pfeldman, 2016-07-11 22:40:55]

pfeldman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[pfeldman, 2016-07-11 22:44:23]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 22:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-07-12 00:42:19]

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
(right):

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:11:
WebInspector.Widget.call(this);
Can we use ThrottledWidget as a base class? You'll save on "isShowing()" guards
in update method and will be able to remove wasShown handler.

As a benefit, we'll throttle requests over the protocol every time a user is
holding down
arrow in Elements Tree => battery savings!

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/SharedSidebarModel.js
(right):

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/SharedSidebarModel.js:1: 
nit: stray line

[commit-bot: I haz the power, 2016-07-12 00:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:52:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-07-12 01:09:43]

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
(right):

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:11:
WebInspector.Widget.call(this);
We are not throttling anything here, so no battery savings.

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/SharedSidebarModel.js
(right):

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/SharedSidebarModel.js:1: 
On 2016/07/12 00:42:19, lushnikov wrote:
> nit: stray line

Done.

[lushnikov, 2016-07-12 01:25:34]

lgtm, please consider using ThrottledWidget. I agree though that it provides
minor savings here.

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
(right):

https://codereview.chromium.org/2140753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:11:
WebInspector.Widget.call(this);
On 2016/07/12 01:09:41, pfeldman wrote:
> We are not throttling anything here, so no battery savings.

If i select a node in elements tree and will hold "down" arrow, this code will
execute "_update" 
synchronously, isn't it? 

Untying unnecessary rendering from input events is a good thing.

[pfeldman, 2016-07-12 01:39:55]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:40:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 03:09:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 03:09:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-07-12 20:47:07]

Description was changed from

==========
DevTools: remove BaseToolbarPaneWidget.
==========

to

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
==========

[pfeldman, 2016-07-12 20:47:12]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-07-12 21:47:40]

Description was changed from

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
==========

to

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true
==========

[pfeldman, 2016-07-12 21:47:45]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-07-12 21:47:53]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:50:46]

Description was changed from

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true
==========

to

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-07-12 21:50:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 21:52:30]

Description was changed from

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true
==========

to

==========
DevTools: remove BaseToolbarPaneWidget.

NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/8a80cbeaa2a3e3fd036022678518871273dc9a46
Cr-Commit-Position: refs/heads/master@{#404840}
==========

[commit-bot: I haz the power, 2016-07-12 21:52:31]

Patchset 2 (id:??) landed as
https://crrev.com/8a80cbeaa2a3e3fd036022678518871273dc9a46
Cr-Commit-Position: refs/heads/master@{#404840}