Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2140753003: DevTools: remove BaseToolbarPaneWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index 5da3bbefc0a7996ff53ddb95a0e92727285c6f61..5b489f664e9b4e3cefecf821a4b707bce15a7a5d 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -134,13 +134,21 @@ WebInspector.ElementsPanel.prototype = {
/**
* @param {?WebInspector.Widget} widget
+ * @param {!WebInspector.ToolbarToggle=} toggle
*/
- showToolbarPane: function(widget)
+ showToolbarPane: function(widget, toggle)
{
+ if (this._pendingWidgetToggle)
+ this._pendingWidgetToggle.setToggled(false);
+ this._pendingWidgetToggle = toggle;
+
if (this._animatedToolbarPane !== undefined)
this._pendingWidget = widget;
else
this._startToolbarPaneAnimation(widget);
+
+ if (widget && toggle)
+ toggle.setToggled(true);
},
/**
@@ -1244,55 +1252,3 @@ WebInspector.ElementsPanel.PseudoStateMarkerDecorator.prototype = {
return { color: "orange", title: WebInspector.UIString("Element state: %s", ":" + WebInspector.CSSModel.fromNode(node).pseudoState(node).join(", :")) };
}
}
-
-/**
- * @constructor
- * @extends {WebInspector.ThrottledWidget}
- * @param {!WebInspector.ToolbarItem} toolbarItem
- */
-WebInspector.ElementsPanel.BaseToolbarPaneWidget = function(toolbarItem)
-{
- WebInspector.ThrottledWidget.call(this);
- this._toolbarItem = toolbarItem;
- WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this._nodeChanged, this);
-}
-
-WebInspector.ElementsPanel.BaseToolbarPaneWidget.prototype = {
- _nodeChanged: function()
- {
- if (!this.isShowing())
- return;
-
- var elementNode = WebInspector.SharedSidebarModel.elementNode(WebInspector.context.flavor(WebInspector.DOMNode));
- this.onNodeChanged(elementNode);
- },
-
- /**
- * @param {?WebInspector.DOMNode} newNode
- * @protected
- */
- onNodeChanged: function(newNode)
- {
- },
-
- /**
- * @override
- */
- willHide: function()
- {
- this._toolbarItem.setToggled(false);
- WebInspector.ThrottledWidget.prototype.willHide.call(this);
- },
-
- /**
- * @override
- */
- wasShown: function()
- {
- this._toolbarItem.setToggled(true);
- this._nodeChanged();
- WebInspector.ThrottledWidget.prototype.wasShown.call(this);
- },
-
- __proto__: WebInspector.ThrottledWidget.prototype
-}

Powered by Google App Engine
This is Rietveld 408576698