net/http/http_stream_factory_impl_job_controller.cc - Issue 2140733002: Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2140733002: Remove HttpStreamFactory::spdy_enabled_ static member and accessors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop half of this CL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_job_controller.cc

diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc

index c9fb091aa697b556e0b9548e152af8f3766a00f3..45a72721299751782142e9e8cbe44760513bd55c 100644

--- a/net/http/http_stream_factory_impl_job_controller.cc

+++ b/net/http/http_stream_factory_impl_job_controller.cc

@@ -750,9 +750,6 @@ HttpStreamFactoryImpl::JobController::GetAlternativeServiceForInternal(

if (alternative_service.protocol >= NPN_SPDY_MINIMUM_VERSION &&

alternative_service.protocol <= NPN_SPDY_MAXIMUM_VERSION) {

- if (!HttpStreamFactory::spdy_enabled())

mef 2016/07/13 18:26:32 It seems that this flag is used to control both sp

Bence 2016/07/15 20:35:33 Ugh, good catch. This was definitely not my inten

- continue;

if (origin.host() != alternative_service.host &&

!session_->params()

.enable_http2_alternative_service_with_different_host) {

« net/http/http_stream_factory_impl_job.cc ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »