net/http/http_stream_factory_impl_job.cc - Issue 2140733002: Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 2140733002: Remove HttpStreamFactory::spdy_enabled_ static member and accessors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop half of this CL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/pref_names.cc ('K') | « net/http/http_stream_factory.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | net/http/http_stream_factory_impl_job_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index a779d7fb7765acc9d22639eff13bf04a9a3c6911..473c8e8268816ce185c9d87353e242a79ada3960 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -1608,8 +1608,7 @@ int HttpStreamFactoryImpl::Job::HandleCertificateError(int error) {

}

void HttpStreamFactoryImpl::Job::SwitchToSpdyMode() {

- if (HttpStreamFactory::spdy_enabled())

- using_spdy_ = true;

+ using_spdy_ = true;

mef 2016/07/13 18:26:32 Does using_spdy_ mean using_h2 now?

Bence 2016/07/15 20:35:33 Yes, it does. Usually "spdy" in the codebase mean

}

void HttpStreamFactoryImpl::Job::ReportJobSucceededForRequest() {